mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Ladislav Michl <oss-lists@triops.cz>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2] busybox: Version bump. 1.35.0 -> 1.36.0
Date: Fri, 6 Jan 2023 12:17:16 +0100	[thread overview]
Message-ID: <Y7gDPInVTbeMmvAs@lenoch> (raw)
In-Reply-To: <20230104091433.2419958-1-christian.melki@t2data.com>

Hi Christian,

one more thing, commit f51d04cbcf2c ("treewide: Consistently use ':'
instead to separate user and group for chown") says:

| Since coreutils 9.1 chown warns when a '.' is used as separator. Fix this
| consistently also for documentation and scripts that are expected to use
| busybox's chown which (up to now) has no problem with '.'.

On Wed, Jan 04, 2023 at 10:14:33AM +0100, Christian Melki wrote:
> After a year of low activity and questionmarks,
> we finally have a new release of busybox.
> Release changelog @ https://busybox.net/
[snip]
> diff --git a/config/busybox/Config.in b/config/busybox/Config.in
> index 329e2f8e8..199cc6ab2 100644
> --- a/config/busybox/Config.in
> +++ b/config/busybox/Config.in
> @@ -267,10 +267,10 @@ config BUSYBOX_FEATURE_SUID_CONFIG
>  
>  	The file has to be owned by user root, group root and has to be
>  	writeable only by root:
> -		(chown 0:0 /etc/busybox.conf; chmod 600 /etc/busybox.conf)
> +		(chown 0.0 /etc/busybox.conf; chmod 600 /etc/busybox.conf)
>  	The busybox executable has to be owned by user root, group
>  	root and has to be setuid root for this to work:
> -		(chown 0:0 /bin/busybox; chmod 4755 /bin/busybox)
> +		(chown 0.0 /bin/busybox; chmod 4755 /bin/busybox)
>  
>  	Robert 'sandman' Griebl has more information here:
>  	<url: http://www.softforge.de/bb/suid.html >.
[snip]
> diff --git a/config/busybox/networking/Config.in b/config/busybox/networking/Config.in
> index 27e0f44ba..3a3ad56d9 100644
> --- a/config/busybox/networking/Config.in
> +++ b/config/busybox/networking/Config.in
> @@ -959,7 +959,7 @@ config BUSYBOX_TELNETD
>  	FEATURE_SUID enabled. And finally, you should make
>  	certain that busybox has been installed setuid root:
>  
> -		chown root:root /bin/busybox
> +		chown root.root /bin/busybox
>  		chmod 4755 /bin/busybox
>  
>  	with all that done, telnetd _should_ work....

Above two changes are reverting that, so it should be probably dropped.

	ladis



  parent reply	other threads:[~2023-01-06 11:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04  9:14 Christian Melki
2023-01-04  9:23 ` Ladislav Michl
2023-01-04 21:17   ` Ladislav Michl
2023-01-06 11:17 ` Ladislav Michl [this message]
2023-01-06 11:19   ` Michael Olbrich
2023-01-06 11:24     ` Ladislav Michl
2023-01-06 16:01 ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7gDPInVTbeMmvAs@lenoch \
    --to=oss-lists@triops.cz \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox