From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 06 Jan 2023 12:17:34 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pDkj8-003PC1-1o for lore@lore.pengutronix.de; Fri, 06 Jan 2023 12:17:34 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pDkj6-0005Gc-0x; Fri, 06 Jan 2023 12:17:32 +0100 Received: from h2.cmg2.smtp.forpsi.com ([81.2.195.189]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDkit-0005GN-0P for ptxdist@pengutronix.de; Fri, 06 Jan 2023 12:17:19 +0100 Received: from lenoch ([91.218.190.200]) by cmgsmtp with ESMTPSA id Dkiqp6ucpv5uIDkisp4uVo; Fri, 06 Jan 2023 12:17:18 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=triops.cz; s=f2019; t=1673003838; bh=1UlY14Y+7Wn0MbG46KiG3FvzbkmCtbD8368rLZHXH7s=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=YYC+ltKTuRJQUvyKRx7rGiVwWWuvEAGOrWg1GWWJ5eh1AnMoKHv3iKUJvQy55quas lvm0wao+obx5FDxu0vQQdFZJYINr/GkAthOqyMr7Cp2UmzFG7fh5bGbPxyqb1cc1Hu lz57E/3vR3dsMZNw1z7+VGW8F4IrZC6wYR6wLmwF+FKhK/lFNKFs8JuQ+arZfKPbxd 8awS2LFPV5xpmeSe4NRnGL7dxEDtPQXCNKUqKCw7yO8nUrG4G7zKCEsOY4KeprjYsJ 6l/+qS043vj8enlDet411BJxsy61DHIRtAmxv+p26FbZhyGa6HMZ6uupGf9XBk3Q9T PNMigVV5aGZfQ== Date: Fri, 6 Jan 2023 12:17:16 +0100 From: Ladislav Michl To: ptxdist@pengutronix.de Message-ID: References: <20230104091433.2419958-1-christian.melki@t2data.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230104091433.2419958-1-christian.melki@t2data.com> X-CMAE-Envelope: MS4wfAjUHiOnLByzk13SqfJ8nALaIk/xQ2nzEFwn1Ue8pqMmN1wZXDJBaohiLyIaRdtvAHkb8KWITWubnMT1BUUyPCeJf3Pa4QGL/t1kN2tE0VlEwTi1tqPK ZYLHIm5y3jCGa5mwUhjYqQBojfvASXk6xoBAKGkcUD0ZezmswenjsLHQ X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.2 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH v2] busybox: Version bump. 1.35.0 -> 1.36.0 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hi Christian, one more thing, commit f51d04cbcf2c ("treewide: Consistently use ':' instead to separate user and group for chown") says: | Since coreutils 9.1 chown warns when a '.' is used as separator. Fix this | consistently also for documentation and scripts that are expected to use | busybox's chown which (up to now) has no problem with '.'. On Wed, Jan 04, 2023 at 10:14:33AM +0100, Christian Melki wrote: > After a year of low activity and questionmarks, > we finally have a new release of busybox. > Release changelog @ https://busybox.net/ [snip] > diff --git a/config/busybox/Config.in b/config/busybox/Config.in > index 329e2f8e8..199cc6ab2 100644 > --- a/config/busybox/Config.in > +++ b/config/busybox/Config.in > @@ -267,10 +267,10 @@ config BUSYBOX_FEATURE_SUID_CONFIG > > The file has to be owned by user root, group root and has to be > writeable only by root: > - (chown 0:0 /etc/busybox.conf; chmod 600 /etc/busybox.conf) > + (chown 0.0 /etc/busybox.conf; chmod 600 /etc/busybox.conf) > The busybox executable has to be owned by user root, group > root and has to be setuid root for this to work: > - (chown 0:0 /bin/busybox; chmod 4755 /bin/busybox) > + (chown 0.0 /bin/busybox; chmod 4755 /bin/busybox) > > Robert 'sandman' Griebl has more information here: > . [snip] > diff --git a/config/busybox/networking/Config.in b/config/busybox/networking/Config.in > index 27e0f44ba..3a3ad56d9 100644 > --- a/config/busybox/networking/Config.in > +++ b/config/busybox/networking/Config.in > @@ -959,7 +959,7 @@ config BUSYBOX_TELNETD > FEATURE_SUID enabled. And finally, you should make > certain that busybox has been installed setuid root: > > - chown root:root /bin/busybox > + chown root.root /bin/busybox > chmod 4755 /bin/busybox > > with all that done, telnetd _should_ work.... Above two changes are reverting that, so it should be probably dropped. ladis