Re: [ptxdist] [PATCH v2] busybox: Version bump. 1.35.0 -> 1.36.0

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Jan 06, 2023 at 12:17:16PM +0100, Ladislav Michl wrote:
> one more thing, commit f51d04cbcf2c ("treewide: Consistently use ':'
> instead to separate user and group for chown") says:
> 
> | Since coreutils 9.1 chown warns when a '.' is used as separator. Fix this
> | consistently also for documentation and scripts that are expected to use
> | busybox's chown which (up to now) has no problem with '.'.
> 
> On Wed, Jan 04, 2023 at 10:14:33AM +0100, Christian Melki wrote:
> > After a year of low activity and questionmarks,
> > we finally have a new release of busybox.
> > Release changelog @ https://busybox.net/
> [snip]
> > diff --git a/config/busybox/Config.in b/config/busybox/Config.in
> > index 329e2f8e8..199cc6ab2 100644
> > --- a/config/busybox/Config.in
> > +++ b/config/busybox/Config.in
> > @@ -267,10 +267,10 @@ config BUSYBOX_FEATURE_SUID_CONFIG
> >  
> >  	The file has to be owned by user root, group root and has to be
> >  	writeable only by root:
> > -		(chown 0:0 /etc/busybox.conf; chmod 600 /etc/busybox.conf)
> > +		(chown 0.0 /etc/busybox.conf; chmod 600 /etc/busybox.conf)
> >  	The busybox executable has to be owned by user root, group
> >  	root and has to be setuid root for this to work:
> > -		(chown 0:0 /bin/busybox; chmod 4755 /bin/busybox)
> > +		(chown 0.0 /bin/busybox; chmod 4755 /bin/busybox)
> >  
> >  	Robert 'sandman' Griebl has more information here:
> >  	<url: http://www.softforge.de/bb/suid.html >.
> [snip]
> > diff --git a/config/busybox/networking/Config.in b/config/busybox/networking/Config.in
> > index 27e0f44ba..3a3ad56d9 100644
> > --- a/config/busybox/networking/Config.in
> > +++ b/config/busybox/networking/Config.in
> > @@ -959,7 +959,7 @@ config BUSYBOX_TELNETD
> >  	FEATURE_SUID enabled. And finally, you should make
> >  	certain that busybox has been installed setuid root:
> >  
> > -		chown root:root /bin/busybox
> > +		chown root.root /bin/busybox
> >  		chmod 4755 /bin/busybox
> >  
> >  	with all that done, telnetd _should_ work....
> 
> Above two changes are reverting that, so it should be probably dropped.

Hi, this is fine. This is an imported file and the commit mentioned above
should not have touched this. It's just a comment anyways so it doesn't
really matter.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |