Re: [ptxdist] Globally define GIT_CEILING_DIRECTORIES?

[Christian Melki <christian.melki@t2data.com>]

On 2/13/23 16:03, Sven Püschel wrote:
> Hi Christian,
> 
> 
>> Just to summarize so I understand this.
>> You want to limit the searching for git repos,
>> so that if it isn't found in the current posix PWD (cwd), it's not a 
>> git repo?
>> I'm assuming it's expandable by doing an export to $PWD?
> 
> I only want to limit the parent search at a specific directory, not to 
> the current directory. Practically I'm using DistroKit as a BSP with 
> PTXDist. The target package (e.g. sockperf) is downloaded and extracted 
> to /path/to/DistroKit/platform-v8a/build-target/sockperf-3.10 . 
> Currently sockperf executes "git rev-parse HEAD" to get the current 
> commit, that is attached to the version number. As the sockperf-3.10 
> directory itself isn't a Git directory, git checks the parent 
> directories until it finds the Git repository of DistroKit and returns 
> it's commit hash. This results in sockperf having a Distrokit commit as 
> part of it's version number. lshw as another example used the version 
> tag of Distrokit as it's own version.
> 
> When setting 
> GIT_CEILING_DIR=/path/to/DistroKit/platform-v8a/build-target , then Git 
> will still backtrack, but stop when it reaches the build-target 
> directory. E.g. when 
> /path/to/Distrokit/platform-v8a/build-target/sockperf-3.10 is a Git 
> repository and some buildscript calls git from 
> /path/to/DistroKit/platform-v8a/build-target/sockperf-3.10/src , then 
> Git still traverses the parent directory to find the sockperf Git 
> repository. But if sockperf-3.10 isn't a git repo, it will stop 
> backtracking to the build-target directory and return that it didn't 
> find a git repository.
>
>> Have you tried this as an global?
>> Afaict, sockperf treats this locally?
> 
> I've added it locally to sockperf via
> 
> SOCKPERF_CONF_ENV       := $(CROSS_ENV) GIT_CEILING_DIRECTORIES="$(BUILDDIR)"
> SOCKPERF_MAKE_ENV       := $(CROSS_ENV) GIT_CEILING_DIRECTORIES="$(BUILDDIR)"
> 
> I haven't tried this globally yet, as I'm not that familiar with the 
> PTXDist internals and didn't wanted to spend multiple hours creating a 
> patch and then get the feedback, that there might be a better way to do it.
> 

The different CROSS_ENVs are defined in rules/pre/Rules.make
Maybe test it there?

>> Also, do you have any anecdotal or factual history from other build 
>> environments?
>> Some of them rely extensively on git hashes, ie, repos.
>> They've likely stumbled upon the same question.
> 
> Nope, PTXDist is my first embedded build environment.
> 

\o/ :)

> 
> Best regards
> 
> Sven
>