Re: [ptxdist] Globally define GIT_CEILING_DIRECTORIES?

[Michael Riesch <michael.riesch@wolfvision.net>]

Hi Sven,

On 2/13/23 14:58, Sven Püschel wrote:
> I would suggest globally setting the GIT_CEILING_DIRECTORIES environment
> variable when building packages.
> 
> Besides lshw, sockperf is now the second time I've encountered the
> buildsystem to check the current git repository. But as Git also checks
> the parent directories when searching for Git repositories, these checks
> may result in getting an unwanted Git repository (usually the BSP),
> resulting in package versions with a Git commit/version that has nothing
> to do with the actual package.
> 
> With GIT_CEILING_DIRECTORIES set to the parent directory of the
> extracted sources, Git will stop searching for parent Git repositories,
> when it encounters this directory. See my sockperf v2 patch for an
> example of using this environment variable.

We can add the libcamera project to that list. There is a script inside
libcamera that checks whether the sources are in a git tree. If yes, the
version obtained by git describe is used. As a fallback, the meson
project version is used. As a consequence, the version of our BSP is
leaked into libcamera.

I haven't tested this GIT_CEILING_DIRECTORIES approach but it seems to
me that it would do the trick.

> Given this is a global change, does anyone see a potential problem?

Can't be the judge of that, though.

Best regards,
Michael