Re: [ptxdist] [PATCH] libtahu: Change CFLAGS to use 64-bit system time

[Ian Abbott <abbotti@mev.co.uk>]

On 23/02/2023 15:42, Michael Olbrich wrote:
> On Mon, Feb 20, 2023 at 01:41:05PM +0000, Ian Abbott wrote:
>> diff --git a/rules/libtahu.make b/rules/libtahu.make
>> index 26c064c6d..3e392216d 100644
>> --- a/rules/libtahu.make
>> +++ b/rules/libtahu.make
>> @@ -37,11 +37,12 @@ LIBTAHU_CONF_TOOL	:= NO
>>   # Compile
>>   # ----------------------------------------------------------------------------
>>   
>> -#LIBTAHU_MAKE_ENV	:= $(CROSS_ENV)
>> -
>> +LIBTAHU_CPPFLAGS := -Iinclude -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64
>> +LIBTAHU_CFLAGS := -O2 -g -g3 -fPIC
> 
> No need to mess with the existing CFLAGS. You can inject extra CFLAGS
> though the toolchain wrappers. And for correctness, make it conditional:
> 
> ifdef PTXCONF_GLOBAL_LARGE_FILE
> LIBTAHU_CFLAGS := -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64
> endif
> 
> nothing else is needed.

libtahu does not actually use files, large or otherwise.  It's the 
64-bit time support that I want, not the large file support.  However 
glibc does not support _TIME_BITS=64 unless _FILE_OFFSET_BITS=64, so 
that needs to come along for the ride.

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-