Re: [ptxdist] [PATCH] libtahu: Change CFLAGS to use 64-bit system time

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Feb 24, 2023 at 09:55:12AM +0000, Ian Abbott wrote:
> On 23/02/2023 15:42, Michael Olbrich wrote:
> > On Mon, Feb 20, 2023 at 01:41:05PM +0000, Ian Abbott wrote:
> > > diff --git a/rules/libtahu.make b/rules/libtahu.make
> > > index 26c064c6d..3e392216d 100644
> > > --- a/rules/libtahu.make
> > > +++ b/rules/libtahu.make
> > > @@ -37,11 +37,12 @@ LIBTAHU_CONF_TOOL	:= NO
> > >   # Compile
> > >   # ----------------------------------------------------------------------------
> > > -#LIBTAHU_MAKE_ENV	:= $(CROSS_ENV)
> > > -
> > > +LIBTAHU_CPPFLAGS := -Iinclude -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64
> > > +LIBTAHU_CFLAGS := -O2 -g -g3 -fPIC
> > 
> > No need to mess with the existing CFLAGS. You can inject extra CFLAGS
> > though the toolchain wrappers. And for correctness, make it conditional:
> > 
> > ifdef PTXCONF_GLOBAL_LARGE_FILE
> > LIBTAHU_CFLAGS := -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64
> > endif
> > 
> > nothing else is needed.
> 
> libtahu does not actually use files, large or otherwise.  It's the 64-bit
> time support that I want, not the large file support.  However glibc does
> not support _TIME_BITS=64 unless _FILE_OFFSET_BITS=64, so that needs to come
> along for the ride.

I just read _FILE_OFFSET_BITS=64 and that matched with
PTXCONF_GLOBAL_LARGE_FILE in my brain... :-)

Anyways, making it conditionally like that is actually correct in some
ways, because as you said, you need the large file stuff anyways before the
64bit time stuff can be enabled.

But I'm not so sure any more, if that patch makes sense in general:
This is not something that should be enabled for a single package and
adding cflags to every package does not scale.

Doing that for PTXdist as a whole is on my todo list but I've not had the
time to implement this.

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |