From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 24 Feb 2023 10:55:43 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pVUnn-000ekz-79 for lore@lore.pengutronix.de; Fri, 24 Feb 2023 10:55:43 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pVUnm-0007Io-7p; Fri, 24 Feb 2023 10:55:42 +0100 Received: from smtp115.iad3b.emailsrvr.com ([146.20.161.115]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVUnM-0007HZ-00 for ptxdist@pengutronix.de; Fri, 24 Feb 2023 10:55:16 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20221208-6x11dpa4; t=1677232513; bh=gzKCpZvI8iCKdWcKlHeeMjrVqxRS6LozawrIuVBnbp4=; h=Date:Subject:To:From:From; b=ONbiN5FsKJ4/teMynTIfj5X12OutlEMgavzDrPM50zJ5OnN5VO6d2I3Y01KTfD+F3 H8tNs4Re2X82wmMU2+ZiTYSd5e30Rm5NZbEtm0qZGcZ3Bx4qWCy/Obx3FTro2jRWqS KhwfQEQ7d/cRquNPb8UohARX3iSjpcEYXzDlENpo= X-Auth-ID: abbotti@mev.co.uk Received: by smtp23.relay.iad3b.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id A1D7AA00A6 for ; Fri, 24 Feb 2023 04:55:13 -0500 (EST) Message-ID: <3cbe455b-9922-87bc-aa8e-60588d3b8e3e@mev.co.uk> Date: Fri, 24 Feb 2023 09:55:12 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-GB To: ptxdist@pengutronix.de References: <20230220134105.28904-1-abbotti@mev.co.uk> From: Ian Abbott Organization: MEV Ltd. In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Classification-ID: 6a75390c-7de7-4464-94f6-cd914b6b8bd5-1-1 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.9 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH] libtahu: Change CFLAGS to use 64-bit system time X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On 23/02/2023 15:42, Michael Olbrich wrote: > On Mon, Feb 20, 2023 at 01:41:05PM +0000, Ian Abbott wrote: >> diff --git a/rules/libtahu.make b/rules/libtahu.make >> index 26c064c6d..3e392216d 100644 >> --- a/rules/libtahu.make >> +++ b/rules/libtahu.make >> @@ -37,11 +37,12 @@ LIBTAHU_CONF_TOOL := NO >> # Compile >> # ---------------------------------------------------------------------------- >> >> -#LIBTAHU_MAKE_ENV := $(CROSS_ENV) >> - >> +LIBTAHU_CPPFLAGS := -Iinclude -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 >> +LIBTAHU_CFLAGS := -O2 -g -g3 -fPIC > > No need to mess with the existing CFLAGS. You can inject extra CFLAGS > though the toolchain wrappers. And for correctness, make it conditional: > > ifdef PTXCONF_GLOBAL_LARGE_FILE > LIBTAHU_CFLAGS := -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 > endif > > nothing else is needed. libtahu does not actually use files, large or otherwise. It's the 64-bit time support that I want, not the large file support. However glibc does not support _TIME_BITS=64 unless _FILE_OFFSET_BITS=64, so that needs to come along for the ride. -- -=( Ian Abbott || MEV Ltd. is a company )=- -=( registered in England & Wales. Regd. number: 02862268. )=- -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=- -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-