mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] git-ptx-refresh-tags-editor: use mktemp instead of tempfile
@ 2024-02-12  9:22 Roland Hieber
  2024-02-14 16:19 ` [ptxdist] [APPLIED] " Michael Olbrich
  0 siblings, 1 reply; 2+ messages in thread
From: Roland Hieber @ 2024-02-12  9:22 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

On Debian 12 (bookworm), tempfile comes from debianutils, and prints a
deprecation warning:

  WARNING: tempfile is deprecated; consider using mktemp instead.

Switch to mktemp from coreutils, which is widely available.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 scripts/git-ptx-refresh-tags-editor | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/git-ptx-refresh-tags-editor b/scripts/git-ptx-refresh-tags-editor
index fcc9c78f3c7d..0177ad3a0194 100755
--- a/scripts/git-ptx-refresh-tags-editor
+++ b/scripts/git-ptx-refresh-tags-editor
@@ -26,7 +26,7 @@ push_tags() {
 
 filter_rebase() {
 	file="${1}"
-	tmpfile="$(tempfile -d "$(dirname "${file}")" -p "$(basename ${file}).")"
+	tmpfile="$(mktemp "${file}.XXXXX")"
 	tags=
 	cat "${file}" | while read cmd commitish subject; do
 		case "${cmd}" in
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [ptxdist] [APPLIED] git-ptx-refresh-tags-editor: use mktemp instead of tempfile
  2024-02-12  9:22 [ptxdist] [PATCH] git-ptx-refresh-tags-editor: use mktemp instead of tempfile Roland Hieber
@ 2024-02-14 16:19 ` Michael Olbrich
  0 siblings, 0 replies; 2+ messages in thread
From: Michael Olbrich @ 2024-02-14 16:19 UTC (permalink / raw)
  To: ptxdist; +Cc: Roland Hieber

Thanks, applied as 5b5bad3ef8d0c8c75f31449f8fdb29d4010e9c5b.

Michael

[sent from post-receive hook]

On Wed, 14 Feb 2024 17:19:25 +0100, Roland Hieber <rhi@pengutronix.de> wrote:
> On Debian 12 (bookworm), tempfile comes from debianutils, and prints a
> deprecation warning:
> 
>   WARNING: tempfile is deprecated; consider using mktemp instead.
> 
> Switch to mktemp from coreutils, which is widely available.
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20240212092200.1514323-1-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/scripts/git-ptx-refresh-tags-editor b/scripts/git-ptx-refresh-tags-editor
> index fcc9c78f3c7d..0177ad3a0194 100755
> --- a/scripts/git-ptx-refresh-tags-editor
> +++ b/scripts/git-ptx-refresh-tags-editor
> @@ -26,7 +26,7 @@ push_tags() {
>  
>  filter_rebase() {
>  	file="${1}"
> -	tmpfile="$(tempfile -d "$(dirname "${file}")" -p "$(basename ${file}).")"
> +	tmpfile="$(mktemp "${file}.XXXXX")"
>  	tags=
>  	cat "${file}" | while read cmd commitish subject; do
>  		case "${cmd}" in



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-14 16:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-12  9:22 [ptxdist] [PATCH] git-ptx-refresh-tags-editor: use mktemp instead of tempfile Roland Hieber
2024-02-14 16:19 ` [ptxdist] [APPLIED] " Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox