From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Wed, 14 Feb 2024 17:20:07 +0100
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1raHzT-006LRR-0H
	for lore@lore.pengutronix.de;
	Wed, 14 Feb 2024 17:20:07 +0100
Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de)
	by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1raHzS-0006PW-Rb; Wed, 14 Feb 2024 17:20:06 +0100
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.whiteo.stw.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1raHyo-00060x-CI; Wed, 14 Feb 2024 17:19:26 +0100
Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1raHyn-000iyv-W0; Wed, 14 Feb 2024 17:19:26 +0100
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96)
 (envelope-from <mol@pengutronix.de>) id 1raHyn-001uf7-33;
 Wed, 14 Feb 2024 17:19:25 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Wed, 14 Feb 2024 17:19:25 +0100
Message-Id: <20240214161925.456130-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20240212092200.1514323-1-rhi@pengutronix.de>
References: <20240212092200.1514323-1-rhi@pengutronix.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] git-ptx-refresh-tags-editor: use mktemp
 instead of tempfile
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <https://metis.pengutronix.de/mailman/options/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <https://metis.pengutronix.de/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <https://metis.pengutronix.de/mailman/listinfo/ptxdist>,
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 5b5bad3ef8d0c8c75f31449f8fdb29d4010e9c5b.

Michael

[sent from post-receive hook]

On Wed, 14 Feb 2024 17:19:25 +0100, Roland Hieber <rhi@pengutronix.de> wrote:
> On Debian 12 (bookworm), tempfile comes from debianutils, and prints a
> deprecation warning:
> 
>   WARNING: tempfile is deprecated; consider using mktemp instead.
> 
> Switch to mktemp from coreutils, which is widely available.
> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20240212092200.1514323-1-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/scripts/git-ptx-refresh-tags-editor b/scripts/git-ptx-refresh-tags-editor
> index fcc9c78f3c7d..0177ad3a0194 100755
> --- a/scripts/git-ptx-refresh-tags-editor
> +++ b/scripts/git-ptx-refresh-tags-editor
> @@ -26,7 +26,7 @@ push_tags() {
>  
>  filter_rebase() {
>  	file="${1}"
> -	tmpfile="$(tempfile -d "$(dirname "${file}")" -p "$(basename ${file}).")"
> +	tmpfile="$(mktemp "${file}.XXXXX")"
>  	tags=
>  	cat "${file}" | while read cmd commitish subject; do
>  		case "${cmd}" in