* [ptxdist] [PATCH] host-libslirp: should not have a prompt
@ 2023-03-16 16:57 Roland Hieber
2023-03-17 6:55 ` Michael Olbrich
0 siblings, 1 reply; 4+ messages in thread
From: Roland Hieber @ 2023-03-16 16:57 UTC (permalink / raw)
To: ptxdist; +Cc: Roland Hieber
It's in the hosttools_noprompt section.
Fixes: 81fbc066ec4975fbfd0f (2023-03-12, "libslirp: new package: user-mode networking library used by qemu")
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
rules/host-libslirp.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/rules/host-libslirp.in b/rules/host-libslirp.in
index d0a9f211f89a..b47c69d215c4 100644
--- a/rules/host-libslirp.in
+++ b/rules/host-libslirp.in
@@ -4,4 +4,3 @@ config HOST_LIBSLIRP
tristate
select HOST_GLIB
select HOST_MESON
- prompt "libslirp"
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [PATCH] host-libslirp: should not have a prompt
2023-03-16 16:57 [ptxdist] [PATCH] host-libslirp: should not have a prompt Roland Hieber
@ 2023-03-17 6:55 ` Michael Olbrich
2023-03-17 9:33 ` [ptxdist] [PATCH v2] host-libslirp: should not have a prompt, but build it in ALLYES Roland Hieber
0 siblings, 1 reply; 4+ messages in thread
From: Michael Olbrich @ 2023-03-17 6:55 UTC (permalink / raw)
To: Roland Hieber, ptxdist
On Thu, Mar 16, 2023 at 05:57:12PM +0100, Roland Hieber wrote:
> It's in the hosttools_noprompt section.
>
> Fixes: 81fbc066ec4975fbfd0f (2023-03-12, "libslirp: new package: user-mode networking library used by qemu")
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
> rules/host-libslirp.in | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/rules/host-libslirp.in b/rules/host-libslirp.in
> index d0a9f211f89a..b47c69d215c4 100644
> --- a/rules/host-libslirp.in
> +++ b/rules/host-libslirp.in
> @@ -4,4 +4,3 @@ config HOST_LIBSLIRP
> tristate
> select HOST_GLIB
> select HOST_MESON
> - prompt "libslirp"
Can you add this instead:
default y if ALLYES
This way it is always build in ALLYES test builds. All host packages should
have this.
Michael
> --
> 2.30.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ptxdist] [PATCH v2] host-libslirp: should not have a prompt, but build it in ALLYES
2023-03-17 6:55 ` Michael Olbrich
@ 2023-03-17 9:33 ` Roland Hieber
2023-03-24 9:03 ` [ptxdist] [APPLIED] " Michael Olbrich
0 siblings, 1 reply; 4+ messages in thread
From: Roland Hieber @ 2023-03-17 9:33 UTC (permalink / raw)
To: ptxdist; +Cc: Roland Hieber
It's in the hosttools_noprompt section after all, and this way it gets
compile-tested in ALLYES builds.
Fixes: 81fbc066ec4975fbfd0f (2023-03-12, "libslirp: new package: user-mode networking library used by qemu")
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
v1-> v2: include in ALLYES builds
rules/host-libslirp.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rules/host-libslirp.in b/rules/host-libslirp.in
index d0a9f211f89a..e61e2b64b05e 100644
--- a/rules/host-libslirp.in
+++ b/rules/host-libslirp.in
@@ -2,6 +2,6 @@
config HOST_LIBSLIRP
tristate
+ default y if ALLYES
select HOST_GLIB
select HOST_MESON
- prompt "libslirp"
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ptxdist] [APPLIED] host-libslirp: should not have a prompt, but build it in ALLYES
2023-03-17 9:33 ` [ptxdist] [PATCH v2] host-libslirp: should not have a prompt, but build it in ALLYES Roland Hieber
@ 2023-03-24 9:03 ` Michael Olbrich
0 siblings, 0 replies; 4+ messages in thread
From: Michael Olbrich @ 2023-03-24 9:03 UTC (permalink / raw)
To: ptxdist; +Cc: Roland Hieber
Thanks, applied as 48f2bbc97be95b4652b7cea056c65e62ff2ae3e5.
Michael
[sent from post-receive hook]
On Fri, 24 Mar 2023 10:03:35 +0100, Roland Hieber <rhi@pengutronix.de> wrote:
> It's in the hosttools_noprompt section after all, and this way it gets
> compile-tested in ALLYES builds.
>
> Fixes: 81fbc066ec4975fbfd0f (2023-03-12, "libslirp: new package: user-mode networking library used by qemu")
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> Message-Id: <20230317093356.1062758-1-rhi@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/host-libslirp.in b/rules/host-libslirp.in
> index d0a9f211f89a..e61e2b64b05e 100644
> --- a/rules/host-libslirp.in
> +++ b/rules/host-libslirp.in
> @@ -2,6 +2,6 @@
>
> config HOST_LIBSLIRP
> tristate
> + default y if ALLYES
> select HOST_GLIB
> select HOST_MESON
> - prompt "libslirp"
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-24 9:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-16 16:57 [ptxdist] [PATCH] host-libslirp: should not have a prompt Roland Hieber
2023-03-17 6:55 ` Michael Olbrich
2023-03-17 9:33 ` [ptxdist] [PATCH v2] host-libslirp: should not have a prompt, but build it in ALLYES Roland Hieber
2023-03-24 9:03 ` [ptxdist] [APPLIED] " Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox