mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>, ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] host-libslirp: should not have a prompt
Date: Fri, 17 Mar 2023 07:55:03 +0100	[thread overview]
Message-ID: <ZBQOx1Dpxf9NYR0m@pengutronix.de> (raw)
In-Reply-To: <20230316165712.426164-1-rhi@pengutronix.de>

On Thu, Mar 16, 2023 at 05:57:12PM +0100, Roland Hieber wrote:
> It's in the hosttools_noprompt section.
> 
> Fixes: 81fbc066ec4975fbfd0f (2023-03-12, "libslirp: new package: user-mode networking library used by qemu")
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  rules/host-libslirp.in | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/rules/host-libslirp.in b/rules/host-libslirp.in
> index d0a9f211f89a..b47c69d215c4 100644
> --- a/rules/host-libslirp.in
> +++ b/rules/host-libslirp.in
> @@ -4,4 +4,3 @@ config HOST_LIBSLIRP
>  	tristate
>  	select HOST_GLIB
>  	select HOST_MESON
> -	prompt "libslirp"

Can you add this instead:

	default y if ALLYES

This way it is always build in ALLYES test builds. All host packages should
have this.

Michael

> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2023-03-17  6:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-16 16:57 Roland Hieber
2023-03-17  6:55 ` Michael Olbrich [this message]
2023-03-17  9:33   ` [ptxdist] [PATCH v2] host-libslirp: should not have a prompt, but build it in ALLYES Roland Hieber
2023-03-24  9:03     ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBQOx1Dpxf9NYR0m@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --cc=rhi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox