From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Artur Wiebe <artur@4wiebe.de>
Subject: Re: [ptxdist] [APPLIED] php8: enable short tags
Date: Fri, 17 Feb 2023 16:35:55 +0100 [thread overview]
Message-ID: <20230217153555.1280703-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20230215193301.1603364-1-artur@4wiebe.de>
Thanks, applied as 8a6b5aca325bf4165b9dfc723ca1c8695f1ab161.
Michael
[sent from post-receive hook]
On Fri, 17 Feb 2023 16:35:54 +0100, Artur Wiebe <artur@4wiebe.de> wrote:
> Is there any reason not to enable them by default?
>
> >From documentation:
> Short tags are available by default but can be disabled either via the short_open_tag php.ini configuration file directive,
> or are disabled by default if PHP is built with the --disable-short-tags configuration.
>
> Signed-off-by: Artur Wiebe <artur@4wiebe.de>
> Message-Id: <20230215193301.1603364-1-artur@4wiebe.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/php8.make b/rules/php8.make
> index 212a1c382c10..131cd567a3c5 100644
> --- a/rules/php8.make
> +++ b/rules/php8.make
> @@ -77,7 +77,7 @@ PHP8_CONF_OPT := \
> --without-config-file-scan-dir \
> --disable-sigchild \
> --disable-libgcc \
> - --disable-short-tags \
> + --enable-short-tags \
> --disable-dmalloc \
> --$(call ptx/endis, PTXCONF_GLOBAL_IPV6)-ipv6 \
> --disable-dtrace \
prev parent reply other threads:[~2023-02-17 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 19:33 [ptxdist] [PATCH] " Artur Wiebe
2023-02-17 15:35 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217153555.1280703-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=artur@4wiebe.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox