From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Fri, 17 Feb 2023 16:36:30 +0100
Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1pT2mk-00AE69-RC
	for lore@lore.pengutronix.de; Fri, 17 Feb 2023 16:36:30 +0100
Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de)
	by metis.ext.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1pT2mk-0004BR-Au; Fri, 17 Feb 2023 16:36:30 +0100
Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2])
 by metis.ext.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <mol@pengutronix.de>)
 id 1pT2mC-00024J-OB; Fri, 17 Feb 2023 16:35:56 +0100
Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de)
 by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1pT2mA-005cKj-Id; Fri, 17 Feb 2023 16:35:55 +0100
Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.94.2)
 (envelope-from <mol@pengutronix.de>)
 id 1pT2mB-005NTX-6F; Fri, 17 Feb 2023 16:35:55 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Date: Fri, 17 Feb 2023 16:35:55 +0100
Message-Id: <20230217153555.1280703-1-m.olbrich@pengutronix.de>
X-Mailer: git-send-email 2.30.2
In-Reply-To: <20230215193301.1603364-1-artur@4wiebe.de>
References: <20230215193301.1603364-1-artur@4wiebe.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [ptxdist] [APPLIED] php8: enable short tags
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: Artur Wiebe <artur@4wiebe.de>
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false

Thanks, applied as 8a6b5aca325bf4165b9dfc723ca1c8695f1ab161.

Michael

[sent from post-receive hook]

On Fri, 17 Feb 2023 16:35:54 +0100, Artur Wiebe <artur@4wiebe.de> wrote:
> Is there any reason not to enable them by default?
> 
> >From documentation:
> Short tags are available by default but can be disabled either via the short_open_tag php.ini configuration file directive,
> or are disabled by default if PHP is built with the --disable-short-tags configuration.
> 
> Signed-off-by: Artur Wiebe <artur@4wiebe.de>
> Message-Id: <20230215193301.1603364-1-artur@4wiebe.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/php8.make b/rules/php8.make
> index 212a1c382c10..131cd567a3c5 100644
> --- a/rules/php8.make
> +++ b/rules/php8.make
> @@ -77,7 +77,7 @@ PHP8_CONF_OPT := \
>  	--without-config-file-scan-dir \
>  	--disable-sigchild \
>  	--disable-libgcc \
> -	--disable-short-tags \
> +	--enable-short-tags \
>  	--disable-dmalloc \
>  	--$(call ptx/endis, PTXCONF_GLOBAL_IPV6)-ipv6 \
>  	--disable-dtrace \