[ptxdist] [PATCH] php8: enable short tags

[ptxdist] [PATCH] php8: enable short tags

[Artur Wiebe]

Is there any reason not to enable them by default?

>From documentation:
Short tags are available by default but can be disabled either via the short_open_tag php.ini configuration file directive,
or are disabled by default if PHP is built with the --disable-short-tags configuration.

Signed-off-by: Artur Wiebe <artur@4wiebe.de>
---
 rules/php8.make | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/php8.make b/rules/php8.make
index 212a1c382..131cd567a 100644
--- a/rules/php8.make
+++ b/rules/php8.make
@@ -77,7 +77,7 @@ PHP8_CONF_OPT := \
 	--without-config-file-scan-dir \
 	--disable-sigchild \
 	--disable-libgcc \
-	--disable-short-tags \
+	--enable-short-tags \
 	--disable-dmalloc \
 	--$(call ptx/endis, PTXCONF_GLOBAL_IPV6)-ipv6 \
 	--disable-dtrace \
-- 
2.39.1

Re: [ptxdist] [APPLIED] php8: enable short tags

[Michael Olbrich]

Thanks, applied as 8a6b5aca325bf4165b9dfc723ca1c8695f1ab161.

Michael

[sent from post-receive hook]

On Fri, 17 Feb 2023 16:35:54 +0100, Artur Wiebe <artur@4wiebe.de> wrote:
> Is there any reason not to enable them by default?
> 
> >From documentation:
> Short tags are available by default but can be disabled either via the short_open_tag php.ini configuration file directive,
> or are disabled by default if PHP is built with the --disable-short-tags configuration.
> 
> Signed-off-by: Artur Wiebe <artur@4wiebe.de>
> Message-Id: <20230215193301.1603364-1-artur@4wiebe.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/php8.make b/rules/php8.make
> index 212a1c382c10..131cd567a3c5 100644
> --- a/rules/php8.make
> +++ b/rules/php8.make
> @@ -77,7 +77,7 @@ PHP8_CONF_OPT := \
>  	--without-config-file-scan-dir \
>  	--disable-sigchild \
>  	--disable-libgcc \
> -	--disable-short-tags \
> +	--enable-short-tags \
>  	--disable-dmalloc \
>  	--$(call ptx/endis, PTXCONF_GLOBAL_IPV6)-ipv6 \
>  	--disable-dtrace \