mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Alexander Dahl <ada@thorsis.com>
Subject: Re: [ptxdist] [APPLIED] u-boot: Use host pkg-config to find host tool dependencies
Date: Fri,  5 Aug 2022 09:51:04 +0200	[thread overview]
Message-ID: <20220805075104.3718640-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20220803131114.6722-1-ada@thorsis.com>

Thanks, applied as 3964c01e6b5f0ba1076742cb5207966c10d8fda3.

Michael

[sent from post-receive hook]

On Fri, 05 Aug 2022 09:51:04 +0200, Alexander Dahl <ada@thorsis.com> wrote:
> Since U-Boot version 2015.07 U-Boot host tools might require
> host-openssl, depending on options set in U-Boot Kconfig.
> 
> An option to depend on host openssl was added to ptxdist with commit
> 0c779a60e50c ("u-boot: Add option to depend on host-openssl") already.
> This is not enough however, because 'sysroot-cross/bin/pkg-config' is
> used instead of 'sysroot-host/bin/pkg-config' to discover libssl
> dependencies.  This might not lead to build failures right away because
> U-Boot has a fallback in its tools/Makefile masking the problem.  The
> problem might also be masked if a libssl-dev is installed on the build
> host (outside of ptxdist).
> 
> Using the same approach as barebox package template does since commit
> 1d7a4f8374d0 ("template-barebox-make: make sure the correct pkg-config
> is used") lets ptxdist call the correct pkg-config.
> 
> Note: you can not backport this change to ptxdist lower than 2018.09.0,
> see link below for detailed discussion.
> 
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> Link: https://lore.ptxdist.org/ptxdist/10086649.DBdDmKp7kz@ada/T/#t
> Message-Id: <20220803131114.6722-1-ada@thorsis.com>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/u-boot.make b/rules/u-boot.make
> index ac5a7786bc64..cadca4a6bc92 100644
> --- a/rules/u-boot.make
> +++ b/rules/u-boot.make
> @@ -49,6 +49,9 @@ U_BOOT_ENV_IMAGE_CUSTOM_SRC := $(call ptx/in-platformconfigdir, \
>  $(call ptx/cfghash-file, U_BOOT, $(U_BOOT_ENV_IMAGE_CUSTOM_SRC))
>  endif
>  
> +# use host pkg-config for host tools
> +U_BOOT_PATH		:= PATH=$(HOST_PATH)
> +
>  U_BOOT_WRAPPER_BLACKLIST := \
>  	$(PTXDIST_LOWLEVEL_WRAPPER_BLACKLIST)
>  



      reply	other threads:[~2022-08-05  7:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03 13:11 [ptxdist] [PATCH] " Alexander Dahl
2022-08-05  7:51 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220805075104.3718640-1-m.olbrich@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ada@thorsis.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox