mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Alexander Dahl <ada@thorsis.com>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH] u-boot: Use host pkg-config to find host tool dependencies
Date: Wed,  3 Aug 2022 15:11:14 +0200	[thread overview]
Message-ID: <20220803131114.6722-1-ada@thorsis.com> (raw)

Since U-Boot version 2015.07 U-Boot host tools might require
host-openssl, depending on options set in U-Boot Kconfig.

An option to depend on host openssl was added to ptxdist with commit
0c779a60e50c ("u-boot: Add option to depend on host-openssl") already.
This is not enough however, because 'sysroot-cross/bin/pkg-config' is
used instead of 'sysroot-host/bin/pkg-config' to discover libssl
dependencies.  This might not lead to build failures right away because
U-Boot has a fallback in its tools/Makefile masking the problem.  The
problem might also be masked if a libssl-dev is installed on the build
host (outside of ptxdist).

Using the same approach as barebox package template does since commit
1d7a4f8374d0 ("template-barebox-make: make sure the correct pkg-config
is used") lets ptxdist call the correct pkg-config.

Note: you can not backport this change to ptxdist lower than 2018.09.0,
see link below for detailed discussion.

Signed-off-by: Alexander Dahl <ada@thorsis.com>
Link: https://lore.ptxdist.org/ptxdist/10086649.DBdDmKp7kz@ada/T/#t
---
 rules/u-boot.make | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/rules/u-boot.make b/rules/u-boot.make
index ac5a7786b..cadca4a6b 100644
--- a/rules/u-boot.make
+++ b/rules/u-boot.make
@@ -49,6 +49,9 @@ U_BOOT_ENV_IMAGE_CUSTOM_SRC := $(call ptx/in-platformconfigdir, \
 $(call ptx/cfghash-file, U_BOOT, $(U_BOOT_ENV_IMAGE_CUSTOM_SRC))
 endif
 
+# use host pkg-config for host tools
+U_BOOT_PATH		:= PATH=$(HOST_PATH)
+
 U_BOOT_WRAPPER_BLACKLIST := \
 	$(PTXDIST_LOWLEVEL_WRAPPER_BLACKLIST)
 

base-commit: faf247a8448d4d9caae487beb54d285ac3a6a1b8
-- 
2.30.2




             reply	other threads:[~2022-08-03 13:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03 13:11 Alexander Dahl [this message]
2022-08-05  7:51 ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220803131114.6722-1-ada@thorsis.com \
    --to=ada@thorsis.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox