From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 05 Aug 2022 09:51:43 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oJs7Q-00CFtb-Su for lore@lore.pengutronix.de; Fri, 05 Aug 2022 09:51:43 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1oJs7S-0008Ci-4J; Fri, 05 Aug 2022 09:51:42 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJs6s-0007Vx-Gx; Fri, 05 Aug 2022 09:51:06 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oJs6p-001qmW-HZ; Fri, 05 Aug 2022 09:51:05 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oJs6q-00FbOq-P1; Fri, 05 Aug 2022 09:51:04 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Date: Fri, 5 Aug 2022 09:51:04 +0200 Message-Id: <20220805075104.3718640-1-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220803131114.6722-1-ada@thorsis.com> References: <20220803131114.6722-1-ada@thorsis.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [ptxdist] [APPLIED] u-boot: Use host pkg-config to find host tool dependencies X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Thanks, applied as 3964c01e6b5f0ba1076742cb5207966c10d8fda3. Michael [sent from post-receive hook] On Fri, 05 Aug 2022 09:51:04 +0200, Alexander Dahl wrote: > Since U-Boot version 2015.07 U-Boot host tools might require > host-openssl, depending on options set in U-Boot Kconfig. > > An option to depend on host openssl was added to ptxdist with commit > 0c779a60e50c ("u-boot: Add option to depend on host-openssl") already. > This is not enough however, because 'sysroot-cross/bin/pkg-config' is > used instead of 'sysroot-host/bin/pkg-config' to discover libssl > dependencies. This might not lead to build failures right away because > U-Boot has a fallback in its tools/Makefile masking the problem. The > problem might also be masked if a libssl-dev is installed on the build > host (outside of ptxdist). > > Using the same approach as barebox package template does since commit > 1d7a4f8374d0 ("template-barebox-make: make sure the correct pkg-config > is used") lets ptxdist call the correct pkg-config. > > Note: you can not backport this change to ptxdist lower than 2018.09.0, > see link below for detailed discussion. > > Signed-off-by: Alexander Dahl > Link: https://lore.ptxdist.org/ptxdist/10086649.DBdDmKp7kz@ada/T/#t > Message-Id: <20220803131114.6722-1-ada@thorsis.com> > Signed-off-by: Michael Olbrich > > diff --git a/rules/u-boot.make b/rules/u-boot.make > index ac5a7786bc64..cadca4a6bc92 100644 > --- a/rules/u-boot.make > +++ b/rules/u-boot.make > @@ -49,6 +49,9 @@ U_BOOT_ENV_IMAGE_CUSTOM_SRC := $(call ptx/in-platformconfigdir, \ > $(call ptx/cfghash-file, U_BOOT, $(U_BOOT_ENV_IMAGE_CUSTOM_SRC)) > endif > > +# use host pkg-config for host tools > +U_BOOT_PATH := PATH=$(HOST_PATH) > + > U_BOOT_WRAPPER_BLACKLIST := \ > $(PTXDIST_LOWLEVEL_WRAPPER_BLACKLIST) >