mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 3/4] dhcp: warn in the menu if nothing is installed into the rootfs
Date: Mon, 28 Jun 2021 08:22:12 +0200	[thread overview]
Message-ID: <20210628062212.GI25044@pengutronix.de> (raw)
In-Reply-To: <20210626201649.wlhk2ldnxdqf643f@pengutronix.de>

On Sat, Jun 26, 2021 at 10:16:49PM +0200, Roland Hieber wrote:
> On Fri, Jun 25, 2021 at 09:58:18AM +0200, Michael Olbrich wrote:
> > On Sun, Jun 20, 2021 at 07:10:45PM +0200, Roland Hieber wrote:
> > > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > > ---
> > >  rules/dhcp.in | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/rules/dhcp.in b/rules/dhcp.in
> > > index 859b939eebc9..06ba29080f2c 100644
> > > --- a/rules/dhcp.in
> > > +++ b/rules/dhcp.in
> > > @@ -1,4 +1,8 @@
> > >  ## SECTION=networking
> > > +
> > > +comment "Note: no DHCP binaries are currently selected"
> > > +	depends on DHCP && !DHCP_SERVER && !DHCP_CLIENT && !DHCP_RELAY
> > > +
> > 
> > I think this should be below the 'dhcp' entry in the menu.
> 
> Yes, I think so too, but I couldn't get it to work, it always showed up
> in the isc-dhcp submenu even when I added it after the "endif" :-/

The trick is to put an invisible comment in between. I've applied it with a
fixup.

Michael


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


  reply	other threads:[~2021-06-28  6:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-20 17:10 [ptxdist] [PATCH 1/4] dhcp: always install the config files Roland Hieber
2021-06-20 17:10 ` [ptxdist] [PATCH 2/4] dhcp: set reasonable default options Roland Hieber
2021-06-25  7:57   ` Michael Olbrich
2021-06-20 17:10 ` [ptxdist] [PATCH 3/4] dhcp: warn in the menu if nothing is installed into the rootfs Roland Hieber
2021-06-25  7:58   ` Michael Olbrich
2021-06-26 20:16     ` Roland Hieber
2021-06-28  6:22       ` Michael Olbrich [this message]
2021-06-29  5:09   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-06-20 17:10 ` [ptxdist] [PATCH 4/4] dhcp: sync config files with upstream examples Roland Hieber
2021-06-29  5:09   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-06-29  5:09 ` [ptxdist] [APPLIED] dhcp: always install the config files Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210628062212.GI25044@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    --subject='Re: [ptxdist] [PATCH 3/4] dhcp: warn in the menu if nothing is installed into the rootfs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox