Re: [ptxdist] [PATCH 3/4] dhcp: warn in the menu if nothing is installed into the rootfs

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Sat, Jun 26, 2021 at 10:16:49PM +0200, Roland Hieber wrote:
> On Fri, Jun 25, 2021 at 09:58:18AM +0200, Michael Olbrich wrote:
> > On Sun, Jun 20, 2021 at 07:10:45PM +0200, Roland Hieber wrote:
> > > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > > ---
> > >  rules/dhcp.in | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/rules/dhcp.in b/rules/dhcp.in
> > > index 859b939eebc9..06ba29080f2c 100644
> > > --- a/rules/dhcp.in
> > > +++ b/rules/dhcp.in
> > > @@ -1,4 +1,8 @@
> > >  ## SECTION=networking
> > > +
> > > +comment "Note: no DHCP binaries are currently selected"
> > > +	depends on DHCP && !DHCP_SERVER && !DHCP_CLIENT && !DHCP_RELAY
> > > +
> > 
> > I think this should be below the 'dhcp' entry in the menu.
> 
> Yes, I think so too, but I couldn't get it to work, it always showed up
> in the isc-dhcp submenu even when I added it after the "endif" :-/

The trick is to put an invisible comment in between. I've applied it with a
fixup.

Michael


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de