From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 28 Jun 2021 08:22:53 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lxkfV-000117-Ho for lore@lore.pengutronix.de; Mon, 28 Jun 2021 08:22:53 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lxkfV-0000KJ-Ah; Mon, 28 Jun 2021 08:22:53 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lxkeq-0000KB-Vd for ptxdist@pengutronix.de; Mon, 28 Jun 2021 08:22:12 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lxkeq-0001xa-MQ for ptxdist@pengutronix.de; Mon, 28 Jun 2021 08:22:12 +0200 Date: Mon, 28 Jun 2021 08:22:12 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Message-ID: <20210628062212.GI25044@pengutronix.de> Mail-Followup-To: ptxdist@pengutronix.de References: <20210620171046.25968-1-rhi@pengutronix.de> <20210620171046.25968-3-rhi@pengutronix.de> <20210625075818.GD4006120@pengutronix.de> <20210626201649.wlhk2ldnxdqf643f@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210626201649.wlhk2ldnxdqf643f@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:20:20 up 130 days, 9:44, 109 users, load average: 2.21, 0.99, 0.48 User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH 3/4] dhcp: warn in the menu if nothing is installed into the rootfs X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Sat, Jun 26, 2021 at 10:16:49PM +0200, Roland Hieber wrote: > On Fri, Jun 25, 2021 at 09:58:18AM +0200, Michael Olbrich wrote: > > On Sun, Jun 20, 2021 at 07:10:45PM +0200, Roland Hieber wrote: > > > Signed-off-by: Roland Hieber > > > --- > > > rules/dhcp.in | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/rules/dhcp.in b/rules/dhcp.in > > > index 859b939eebc9..06ba29080f2c 100644 > > > --- a/rules/dhcp.in > > > +++ b/rules/dhcp.in > > > @@ -1,4 +1,8 @@ > > > ## SECTION=networking > > > + > > > +comment "Note: no DHCP binaries are currently selected" > > > + depends on DHCP && !DHCP_SERVER && !DHCP_CLIENT && !DHCP_RELAY > > > + > > > > I think this should be below the 'dhcp' entry in the menu. > > Yes, I think so too, but I couldn't get it to work, it always showed up > in the isc-dhcp submenu even when I added it after the "endif" :-/ The trick is to put an invisible comment in between. I've applied it with a fixup. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de