mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/4] dhcp: set reasonable default options
Date: Fri, 25 Jun 2021 09:57:35 +0200	[thread overview]
Message-ID: <20210625075735.GC4006120@pengutronix.de> (raw)
In-Reply-To: <20210620171046.25968-2-rhi@pengutronix.de>

On Sun, Jun 20, 2021 at 07:10:44PM +0200, Roland Hieber wrote:
> If this package is selected, it is probably because of the server, of
> because the busybox DHCP client was not powerful enough.

Hmm, it's often either of the two, not both. So you would need to change
something anyways. And if both are disabled then it's actually noticeable
at runtime. If it's enabled by default then changes are that nobody notices
that something should be disabled.

Michael

> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  rules/dhcp.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/rules/dhcp.in b/rules/dhcp.in
> index 7eefb16c6414..859b939eebc9 100644
> --- a/rules/dhcp.in
> +++ b/rules/dhcp.in
> @@ -20,6 +20,7 @@ if DHCP
>  
>  config DHCP_SERVER
>  	bool
> +	default y
>  	prompt "DHCP Server dhcpd"
>  	help
>  	  This is the main component of the DHCP server, the daemon process
> @@ -30,6 +31,7 @@ config DHCP_SERVER
>  
>  config DHCP_CLIENT
>  	bool
> +	default y
>  	prompt "DHCP Client dhclient"
>  	help
>  	  This is a client process to provide the system it runs on
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


  reply	other threads:[~2021-06-25  7:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-20 17:10 [ptxdist] [PATCH 1/4] dhcp: always install the config files Roland Hieber
2021-06-20 17:10 ` [ptxdist] [PATCH 2/4] dhcp: set reasonable default options Roland Hieber
2021-06-25  7:57   ` Michael Olbrich [this message]
2021-06-20 17:10 ` [ptxdist] [PATCH 3/4] dhcp: warn in the menu if nothing is installed into the rootfs Roland Hieber
2021-06-25  7:58   ` Michael Olbrich
2021-06-26 20:16     ` Roland Hieber
2021-06-28  6:22       ` Michael Olbrich
2021-06-29  5:09   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-06-20 17:10 ` [ptxdist] [PATCH 4/4] dhcp: sync config files with upstream examples Roland Hieber
2021-06-29  5:09   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-06-29  5:09 ` [ptxdist] [APPLIED] dhcp: always install the config files Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210625075735.GC4006120@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox