mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
* [ptxdist] [PATCH] grpc: add option to enable C# extension
@ 2021-06-08 16:14 Bastian Krause
  2021-06-11  9:13 ` Michael Olbrich
  2021-06-16 10:36 ` [ptxdist] [APPLIED] " Michael Olbrich
  0 siblings, 2 replies; 4+ messages in thread
From: Bastian Krause @ 2021-06-08 16:14 UTC (permalink / raw)
  To: ptxdist; +Cc: Bastian Krause

Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
 rules/grpc.in   | 10 +++++++++-
 rules/grpc.make |  6 +++++-
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/rules/grpc.in b/rules/grpc.in
index d3ae4efaf..2c61c36e2 100644
--- a/rules/grpc.in
+++ b/rules/grpc.in
@@ -1,6 +1,6 @@
 ## SECTION=system_libraries
 
-config GRPC
+menuconfig GRPC
 	tristate
 	select HOST_CMAKE
 	select HOST_GRPC
@@ -18,3 +18,11 @@ config GRPC
 	help
 	  gRPC is a modern, open source, high-performance remote procedure
 	  call (RPC) framework.
+
+if GRPC
+
+config GRPC_CSHARP_EXTENSION
+	bool
+	prompt "C# extension"
+
+endif
diff --git a/rules/grpc.make b/rules/grpc.make
index 1f1b7cf70..85032aafb 100644
--- a/rules/grpc.make
+++ b/rules/grpc.make
@@ -38,7 +38,7 @@ GRPC_CONF_OPT	:= \
 	-DCMAKE_CXX_FLAGS='-Wno-error=ignored-qualifiers' \
 	-DgRPC_BACKWARDS_COMPATIBILITY_MODE=OFF \
 	-DgRPC_BENCHMARK_PROVIDER=none \
-	-DgRPC_BUILD_CSHARP_EXT=OFF \
+	-DgRPC_BUILD_CSHARP_EXT=$(call ptx/onoff, PTXCONF_GRPC_CSHARP_EXTENSION) \
 	-DgRPC_BUILD_TESTS=OFF \
 	-D_gRPC_CARES_LIBRARIES=cares \
 	-DgRPC_CARES_PROVIDER=none \
@@ -84,6 +84,10 @@ $(STATEDIR)/grpc.targetinstall:
 	@$(call install_lib, grpc, 0, 0, 0644, libgrpc)
 	@$(call install_lib, grpc, 0, 0, 0644, libgrpc++)
 
+ifdef PTXCONF_GRPC_CSHARP_EXTENSION
+	@$(call install_lib, grpc, 0, 0, 0644, libgrpc_csharp_ext)
+endif
+
 	@$(call install_finish, grpc)
 
 	@$(call touch)
-- 
2.29.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ptxdist] [PATCH] grpc: add option to enable C# extension
  2021-06-08 16:14 [ptxdist] [PATCH] grpc: add option to enable C# extension Bastian Krause
@ 2021-06-11  9:13 ` Michael Olbrich
  2021-06-11 10:02   ` Bastian Krause
  2021-06-16 10:36 ` [ptxdist] [APPLIED] " Michael Olbrich
  1 sibling, 1 reply; 4+ messages in thread
From: Michael Olbrich @ 2021-06-11  9:13 UTC (permalink / raw)
  To: ptxdist; +Cc: Bastian Krause

On Tue, Jun 08, 2021 at 06:14:21PM +0200, Bastian Krause wrote:
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> ---
>  rules/grpc.in   | 10 +++++++++-
>  rules/grpc.make |  6 +++++-
>  2 files changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/rules/grpc.in b/rules/grpc.in
> index d3ae4efaf..2c61c36e2 100644
> --- a/rules/grpc.in
> +++ b/rules/grpc.in
> @@ -1,6 +1,6 @@
>  ## SECTION=system_libraries
>  
> -config GRPC
> +menuconfig GRPC

With menuconfig, the prompt needs some padding spaces at the end to align
the '-->' in 'ptxdist menuconfig'.

Michael

>  	tristate
>  	select HOST_CMAKE
>  	select HOST_GRPC
> @@ -18,3 +18,11 @@ config GRPC
>  	help
>  	  gRPC is a modern, open source, high-performance remote procedure
>  	  call (RPC) framework.
> +
> +if GRPC
> +
> +config GRPC_CSHARP_EXTENSION
> +	bool
> +	prompt "C# extension"
> +
> +endif
> diff --git a/rules/grpc.make b/rules/grpc.make
> index 1f1b7cf70..85032aafb 100644
> --- a/rules/grpc.make
> +++ b/rules/grpc.make
> @@ -38,7 +38,7 @@ GRPC_CONF_OPT	:= \
>  	-DCMAKE_CXX_FLAGS='-Wno-error=ignored-qualifiers' \
>  	-DgRPC_BACKWARDS_COMPATIBILITY_MODE=OFF \
>  	-DgRPC_BENCHMARK_PROVIDER=none \
> -	-DgRPC_BUILD_CSHARP_EXT=OFF \
> +	-DgRPC_BUILD_CSHARP_EXT=$(call ptx/onoff, PTXCONF_GRPC_CSHARP_EXTENSION) \
>  	-DgRPC_BUILD_TESTS=OFF \
>  	-D_gRPC_CARES_LIBRARIES=cares \
>  	-DgRPC_CARES_PROVIDER=none \
> @@ -84,6 +84,10 @@ $(STATEDIR)/grpc.targetinstall:
>  	@$(call install_lib, grpc, 0, 0, 0644, libgrpc)
>  	@$(call install_lib, grpc, 0, 0, 0644, libgrpc++)
>  
> +ifdef PTXCONF_GRPC_CSHARP_EXTENSION
> +	@$(call install_lib, grpc, 0, 0, 0644, libgrpc_csharp_ext)
> +endif
> +
>  	@$(call install_finish, grpc)
>  
>  	@$(call touch)
> -- 
> 2.29.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ptxdist] [PATCH] grpc: add option to enable C# extension
  2021-06-11  9:13 ` Michael Olbrich
@ 2021-06-11 10:02   ` Bastian Krause
  0 siblings, 0 replies; 4+ messages in thread
From: Bastian Krause @ 2021-06-11 10:02 UTC (permalink / raw)
  To: ptxdist

On 6/11/21 11:13 AM, Michael Olbrich wrote:
> On Tue, Jun 08, 2021 at 06:14:21PM +0200, Bastian Krause wrote:
>> Signed-off-by: Bastian Krause <bst@pengutronix.de>
>> ---
>>  rules/grpc.in   | 10 +++++++++-
>>  rules/grpc.make |  6 +++++-
>>  2 files changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/rules/grpc.in b/rules/grpc.in
>> index d3ae4efaf..2c61c36e2 100644
>> --- a/rules/grpc.in
>> +++ b/rules/grpc.in
>> @@ -1,6 +1,6 @@
>>  ## SECTION=system_libraries
>>  
>> -config GRPC
>> +menuconfig GRPC
> 
> With menuconfig, the prompt needs some padding spaces at the end to align
> the '-->' in 'ptxdist menuconfig'.

The padding spaces in the prompt are already there.

Regards,
Bastian

> 
>>  	tristate
>>  	select HOST_CMAKE
>>  	select HOST_GRPC
>> @@ -18,3 +18,11 @@ config GRPC
>>  	help
>>  	  gRPC is a modern, open source, high-performance remote procedure
>>  	  call (RPC) framework.
>> +
>> +if GRPC
>> +
>> +config GRPC_CSHARP_EXTENSION
>> +	bool
>> +	prompt "C# extension"
>> +
>> +endif
>> diff --git a/rules/grpc.make b/rules/grpc.make
>> index 1f1b7cf70..85032aafb 100644
>> --- a/rules/grpc.make
>> +++ b/rules/grpc.make
>> @@ -38,7 +38,7 @@ GRPC_CONF_OPT	:= \
>>  	-DCMAKE_CXX_FLAGS='-Wno-error=ignored-qualifiers' \
>>  	-DgRPC_BACKWARDS_COMPATIBILITY_MODE=OFF \
>>  	-DgRPC_BENCHMARK_PROVIDER=none \
>> -	-DgRPC_BUILD_CSHARP_EXT=OFF \
>> +	-DgRPC_BUILD_CSHARP_EXT=$(call ptx/onoff, PTXCONF_GRPC_CSHARP_EXTENSION) \
>>  	-DgRPC_BUILD_TESTS=OFF \
>>  	-D_gRPC_CARES_LIBRARIES=cares \
>>  	-DgRPC_CARES_PROVIDER=none \
>> @@ -84,6 +84,10 @@ $(STATEDIR)/grpc.targetinstall:
>>  	@$(call install_lib, grpc, 0, 0, 0644, libgrpc)
>>  	@$(call install_lib, grpc, 0, 0, 0644, libgrpc++)
>>  
>> +ifdef PTXCONF_GRPC_CSHARP_EXTENSION
>> +	@$(call install_lib, grpc, 0, 0, 0644, libgrpc_csharp_ext)
>> +endif
>> +
>>  	@$(call install_finish, grpc)
>>  
>>  	@$(call touch)
>> -- 
>> 2.29.2
>>
>>
>> _______________________________________________
>> ptxdist mailing list
>> ptxdist@pengutronix.de
>> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>>
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [ptxdist] [APPLIED] grpc: add option to enable C# extension
  2021-06-08 16:14 [ptxdist] [PATCH] grpc: add option to enable C# extension Bastian Krause
  2021-06-11  9:13 ` Michael Olbrich
@ 2021-06-16 10:36 ` Michael Olbrich
  1 sibling, 0 replies; 4+ messages in thread
From: Michael Olbrich @ 2021-06-16 10:36 UTC (permalink / raw)
  To: ptxdist; +Cc: Bastian Krause

Thanks, applied as 1558d4bfae77147221bbbb853154932424c2425c.

Michael

[sent from post-receive hook]

On Wed, 16 Jun 2021 12:36:02 +0200, Bastian Krause <bst@pengutronix.de> wrote:
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> Message-Id: <20210608161421.25017-1-bst@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/grpc.in b/rules/grpc.in
> index d3ae4efaff2a..2c61c36e2aec 100644
> --- a/rules/grpc.in
> +++ b/rules/grpc.in
> @@ -1,6 +1,6 @@
>  ## SECTION=system_libraries
>  
> -config GRPC
> +menuconfig GRPC
>  	tristate
>  	select HOST_CMAKE
>  	select HOST_GRPC
> @@ -18,3 +18,11 @@ config GRPC
>  	help
>  	  gRPC is a modern, open source, high-performance remote procedure
>  	  call (RPC) framework.
> +
> +if GRPC
> +
> +config GRPC_CSHARP_EXTENSION
> +	bool
> +	prompt "C# extension"
> +
> +endif
> diff --git a/rules/grpc.make b/rules/grpc.make
> index 1f1b7cf70e21..85032aafbd2b 100644
> --- a/rules/grpc.make
> +++ b/rules/grpc.make
> @@ -38,7 +38,7 @@ GRPC_CONF_OPT	:= \
>  	-DCMAKE_CXX_FLAGS='-Wno-error=ignored-qualifiers' \
>  	-DgRPC_BACKWARDS_COMPATIBILITY_MODE=OFF \
>  	-DgRPC_BENCHMARK_PROVIDER=none \
> -	-DgRPC_BUILD_CSHARP_EXT=OFF \
> +	-DgRPC_BUILD_CSHARP_EXT=$(call ptx/onoff, PTXCONF_GRPC_CSHARP_EXTENSION) \
>  	-DgRPC_BUILD_TESTS=OFF \
>  	-D_gRPC_CARES_LIBRARIES=cares \
>  	-DgRPC_CARES_PROVIDER=none \
> @@ -84,6 +84,10 @@ $(STATEDIR)/grpc.targetinstall:
>  	@$(call install_lib, grpc, 0, 0, 0644, libgrpc)
>  	@$(call install_lib, grpc, 0, 0, 0644, libgrpc++)
>  
> +ifdef PTXCONF_GRPC_CSHARP_EXTENSION
> +	@$(call install_lib, grpc, 0, 0, 0644, libgrpc_csharp_ext)
> +endif
> +
>  	@$(call install_finish, grpc)
>  
>  	@$(call touch)

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-06-16 10:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 16:14 [ptxdist] [PATCH] grpc: add option to enable C# extension Bastian Krause
2021-06-11  9:13 ` Michael Olbrich
2021-06-11 10:02   ` Bastian Krause
2021-06-16 10:36 ` [ptxdist] [APPLIED] " Michael Olbrich

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox