mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Bastian Krause <bst@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] grpc: add option to enable C# extension
Date: Fri, 11 Jun 2021 12:02:56 +0200	[thread overview]
Message-ID: <d44a447d-2922-9672-6d53-d5f797a6175f@pengutronix.de> (raw)
In-Reply-To: <20210611091316.GE839947@pengutronix.de>

On 6/11/21 11:13 AM, Michael Olbrich wrote:
> On Tue, Jun 08, 2021 at 06:14:21PM +0200, Bastian Krause wrote:
>> Signed-off-by: Bastian Krause <bst@pengutronix.de>
>> ---
>>  rules/grpc.in   | 10 +++++++++-
>>  rules/grpc.make |  6 +++++-
>>  2 files changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/rules/grpc.in b/rules/grpc.in
>> index d3ae4efaf..2c61c36e2 100644
>> --- a/rules/grpc.in
>> +++ b/rules/grpc.in
>> @@ -1,6 +1,6 @@
>>  ## SECTION=system_libraries
>>  
>> -config GRPC
>> +menuconfig GRPC
> 
> With menuconfig, the prompt needs some padding spaces at the end to align
> the '-->' in 'ptxdist menuconfig'.

The padding spaces in the prompt are already there.

Regards,
Bastian

> 
>>  	tristate
>>  	select HOST_CMAKE
>>  	select HOST_GRPC
>> @@ -18,3 +18,11 @@ config GRPC
>>  	help
>>  	  gRPC is a modern, open source, high-performance remote procedure
>>  	  call (RPC) framework.
>> +
>> +if GRPC
>> +
>> +config GRPC_CSHARP_EXTENSION
>> +	bool
>> +	prompt "C# extension"
>> +
>> +endif
>> diff --git a/rules/grpc.make b/rules/grpc.make
>> index 1f1b7cf70..85032aafb 100644
>> --- a/rules/grpc.make
>> +++ b/rules/grpc.make
>> @@ -38,7 +38,7 @@ GRPC_CONF_OPT	:= \
>>  	-DCMAKE_CXX_FLAGS='-Wno-error=ignored-qualifiers' \
>>  	-DgRPC_BACKWARDS_COMPATIBILITY_MODE=OFF \
>>  	-DgRPC_BENCHMARK_PROVIDER=none \
>> -	-DgRPC_BUILD_CSHARP_EXT=OFF \
>> +	-DgRPC_BUILD_CSHARP_EXT=$(call ptx/onoff, PTXCONF_GRPC_CSHARP_EXTENSION) \
>>  	-DgRPC_BUILD_TESTS=OFF \
>>  	-D_gRPC_CARES_LIBRARIES=cares \
>>  	-DgRPC_CARES_PROVIDER=none \
>> @@ -84,6 +84,10 @@ $(STATEDIR)/grpc.targetinstall:
>>  	@$(call install_lib, grpc, 0, 0, 0644, libgrpc)
>>  	@$(call install_lib, grpc, 0, 0, 0644, libgrpc++)
>>  
>> +ifdef PTXCONF_GRPC_CSHARP_EXTENSION
>> +	@$(call install_lib, grpc, 0, 0, 0644, libgrpc_csharp_ext)
>> +endif
>> +
>>  	@$(call install_finish, grpc)
>>  
>>  	@$(call touch)
>> -- 
>> 2.29.2
>>
>>
>> _______________________________________________
>> ptxdist mailing list
>> ptxdist@pengutronix.de
>> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>>
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


  reply	other threads:[~2021-06-11 10:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08 16:14 Bastian Krause
2021-06-11  9:13 ` Michael Olbrich
2021-06-11 10:02   ` Bastian Krause [this message]
2021-06-16 10:36 ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d44a447d-2922-9672-6d53-d5f797a6175f@pengutronix.de \
    --to=bst@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox