From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 11 May 2021 17:42:31 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lgUWl-000838-42 for lore@lore.pengutronix.de; Tue, 11 May 2021 17:42:31 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1lgUWk-0007xA-N1; Tue, 11 May 2021 17:42:30 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgUW6-0007x2-F6 for ptxdist@pengutronix.de; Tue, 11 May 2021 17:41:50 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lgUW6-00061v-6O for ptxdist@pengutronix.de; Tue, 11 May 2021 17:41:50 +0200 Date: Tue, 11 May 2021 17:41:50 +0200 From: Michael Olbrich To: ptxdist@pengutronix.de Message-ID: <20210511154150.GE13402@pengutronix.de> Mail-Followup-To: ptxdist@pengutronix.de References: <20210510101948.12089-1-p.zabel@pengutronix.de> <193759b9ef3300d7a2cabfec78ec618c3c87ddd8.camel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <193759b9ef3300d7a2cabfec78ec618c3c87ddd8.camel@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 17:35:09 up 82 days, 18:59, 105 users, load average: 0.03, 0.09, 0.14 User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [ptxdist] [PATCH] libkmod: version bump 27 -> 28 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Tue, May 11, 2021 at 10:08:29AM +0200, Philipp Zabel wrote: > On Mon, 2021-05-10 at 12:19 +0200, Philipp Zabel wrote: > > - add Zstandard compression support, allows to enable the > > kernel CONFIG_MODULE_COMPRESS_ZSTD option > > - LIBKMOD_ZSTD selects HOST_LIBKMOD_ZSTD so depmod understands > > Zstandard during kernel build > > > > Signed-off-by: Philipp Zabel > > --- > > rules/host-libkmod.in | 8 ++++++++ > > rules/host-libkmod.make | 1 + > > rules/libkmod.in | 8 ++++++++ > > rules/libkmod.make | 5 +++-- > > 4 files changed, 20 insertions(+), 2 deletions(-) > > > > diff --git a/rules/host-libkmod.in b/rules/host-libkmod.in > > index dc03abc2a2ab..a32c0e353b19 100644 > > --- a/rules/host-libkmod.in > > +++ b/rules/host-libkmod.in > > @@ -2,4 +2,12 @@ > > > > config HOST_LIBKMOD > > tristate > > + select HOST_ZSTD if HOST_LIBKMOD_ZSTD > > default y if ALLYES > > + > > +if HOST_LIBKMOD > > + > > +config HOST_LIBKMOD_ZSTD > > + bool > > + > > +endif > > diff --git a/rules/host-libkmod.make b/rules/host-libkmod.make > > index 57c8b2ecf9f9..1438eda33424 100644 > > --- a/rules/host-libkmod.make > > +++ b/rules/host-libkmod.make > > @@ -32,6 +32,7 @@ HOST_LIBKMOD_CONF_OPT := \ > > --disable-coverage \ > > --without-xz \ > > --without-zlib \ > > + --$(call ptx/wwo, PTXCONF_HOST_LIBKMOD_ZSTD)-zstd \ > > --without-openssl > > > > # ---------------------------------------------------------------------------- > > diff --git a/rules/libkmod.in b/rules/libkmod.in > > index 1660f7c4b58b..80590a9d0d81 100644 > > --- a/rules/libkmod.in > > +++ b/rules/libkmod.in > > @@ -3,6 +3,8 @@ > > menuconfig LIBKMOD > > tristate > > select ZLIB if LIBKMOD_ZLIB > > + select ZSTD if LIBKMOD_ZSTD > > Of course this is also missing: > > + select HOST_LIBKMOD if LIBKMOD_ZSTD > > > + select HOST_LIBKMOD_ZSTD if LIBKMOD_ZSTD Please align the 'if's. > Would this be the correct way to enable Zstandard support in depmod > during kernel build? It's not easy to find when building the kernel fails, but I don't have a better idea either. But please do the same thing for zlib support to make this consistent. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de