[ptxdist] [PATCH] piglit: add PYTHON3_SSL dependency

[ptxdist] [PATCH] piglit: add PYTHON3_SSL dependency

[Lucas Stach]

Newer versions of the piglit runner require hashlib on the target.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 rules/piglit.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/rules/piglit.in b/rules/piglit.in
index c4414d545cc2..397585c5d26b 100644
--- a/rules/piglit.in
+++ b/rules/piglit.in
@@ -15,6 +15,7 @@ menuconfig PIGLIT
 	select PYTHON3_LZMA
 	select PYTHON3_MAKO
 	select PYTHON3_SIX
+	select PYTHON3_SSL
 	select WAFFLE
 	select WAYLAND if PIGLIT_WAYLAND
 	select LIBXKBCOMMON if PIGLIT_WAYLAND
-- 
2.20.1


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] piglit: add PYTHON3_SSL dependency

[Philipp Zabel]

On Thu, 2020-11-19 at 11:40 +0100, Lucas Stach wrote:
> Newer versions of the piglit runner require hashlib on the target.

Is this a run-time only dependency?

> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  rules/piglit.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rules/piglit.in b/rules/piglit.in
> index c4414d545cc2..397585c5d26b 100644
> --- a/rules/piglit.in
> +++ b/rules/piglit.in
> @@ -15,6 +15,7 @@ menuconfig PIGLIT
>  	select PYTHON3_LZMA
>  	select PYTHON3_MAKO
>  	select PYTHON3_SIX
> +	select PYTHON3_SSL

If so, append "if RUNTIME"?

regards
Philipp

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] piglit: add PYTHON3_SSL dependency

[Lucas Stach]

Am Donnerstag, den 19.11.2020, 12:35 +0100 schrieb Philipp Zabel:
> On Thu, 2020-11-19 at 11:40 +0100, Lucas Stach wrote:
> > Newer versions of the piglit runner require hashlib on the target.
> 
> Is this a run-time only dependency?

Yes, it is ...

> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> >  rules/piglit.in | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/rules/piglit.in b/rules/piglit.in
> > index c4414d545cc2..397585c5d26b 100644
> > --- a/rules/piglit.in
> > +++ b/rules/piglit.in
> > @@ -15,6 +15,7 @@ menuconfig PIGLIT
> >  	select PYTHON3_LZMA
> >  	select PYTHON3_MAKO
> >  	select PYTHON3_SIX
> > +	select PYTHON3_SSL
> 
> If so, append "if RUNTIME"?
 
... however SSL is a suboption of the python3 package, which is not a
runtime only dependency, so adding "if RUNTIME" to this single option
doesn't buy us anything, right?

Regards,
Lucas


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] piglit: add PYTHON3_SSL dependency

[Roland Hieber]

On Thu, Nov 19, 2020 at 12:47:26PM +0100, Lucas Stach wrote:
> Am Donnerstag, den 19.11.2020, 12:35 +0100 schrieb Philipp Zabel:
> > On Thu, 2020-11-19 at 11:40 +0100, Lucas Stach wrote:
> > > Newer versions of the piglit runner require hashlib on the target.
> > 
> > Is this a run-time only dependency?
> 
> Yes, it is ...
> 
> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > ---
> > >  rules/piglit.in | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/rules/piglit.in b/rules/piglit.in
> > > index c4414d545cc2..397585c5d26b 100644
> > > --- a/rules/piglit.in
> > > +++ b/rules/piglit.in
> > > @@ -15,6 +15,7 @@ menuconfig PIGLIT
> > >  	select PYTHON3_LZMA
> > >  	select PYTHON3_MAKO
> > >  	select PYTHON3_SIX
> > > +	select PYTHON3_SSL
> > 
> > If so, append "if RUNTIME"?
>  
> ... however SSL is a suboption of the python3 package, which is not a
> runtime only dependency, so adding "if RUNTIME" to this single option
> doesn't buy us anything, right?

Only if you could also make python itself a runtime-only dependency, so
in this case, you're right.

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [APPLIED] piglit: add PYTHON3_SSL dependency

[Michael Olbrich]

Thanks, applied as abfa8116f37e1a180539f2d633fc06e1714ec4dd.

Michael

[sent from post-receive hook]

On Fri, 27 Nov 2020 09:39:18 +0100, Lucas Stach <l.stach@pengutronix.de> wrote:
> Newer versions of the piglit runner require hashlib on the target.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Message-Id: <20201119104055.31981-1-l.stach@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/piglit.in b/rules/piglit.in
> index c4414d545cc2..397585c5d26b 100644
> --- a/rules/piglit.in
> +++ b/rules/piglit.in
> @@ -15,6 +15,7 @@ menuconfig PIGLIT
>  	select PYTHON3_LZMA
>  	select PYTHON3_MAKO
>  	select PYTHON3_SIX
> +	select PYTHON3_SSL
>  	select WAFFLE
>  	select WAYLAND if PIGLIT_WAYLAND
>  	select LIBXKBCOMMON if PIGLIT_WAYLAND

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de