* [ptxdist] [PATCH] piglit: add PYTHON3_SSL dependency @ 2020-11-19 10:40 Lucas Stach 2020-11-19 11:35 ` Philipp Zabel 2020-11-27 8:39 ` [ptxdist] [APPLIED] " Michael Olbrich 0 siblings, 2 replies; 5+ messages in thread From: Lucas Stach @ 2020-11-19 10:40 UTC (permalink / raw) To: ptxdist Newer versions of the piglit runner require hashlib on the target. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- rules/piglit.in | 1 + 1 file changed, 1 insertion(+) diff --git a/rules/piglit.in b/rules/piglit.in index c4414d545cc2..397585c5d26b 100644 --- a/rules/piglit.in +++ b/rules/piglit.in @@ -15,6 +15,7 @@ menuconfig PIGLIT select PYTHON3_LZMA select PYTHON3_MAKO select PYTHON3_SIX + select PYTHON3_SSL select WAFFLE select WAYLAND if PIGLIT_WAYLAND select LIBXKBCOMMON if PIGLIT_WAYLAND -- 2.20.1 _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] piglit: add PYTHON3_SSL dependency 2020-11-19 10:40 [ptxdist] [PATCH] piglit: add PYTHON3_SSL dependency Lucas Stach @ 2020-11-19 11:35 ` Philipp Zabel 2020-11-19 11:47 ` Lucas Stach 2020-11-27 8:39 ` [ptxdist] [APPLIED] " Michael Olbrich 1 sibling, 1 reply; 5+ messages in thread From: Philipp Zabel @ 2020-11-19 11:35 UTC (permalink / raw) To: ptxdist On Thu, 2020-11-19 at 11:40 +0100, Lucas Stach wrote: > Newer versions of the piglit runner require hashlib on the target. Is this a run-time only dependency? > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > rules/piglit.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/rules/piglit.in b/rules/piglit.in > index c4414d545cc2..397585c5d26b 100644 > --- a/rules/piglit.in > +++ b/rules/piglit.in > @@ -15,6 +15,7 @@ menuconfig PIGLIT > select PYTHON3_LZMA > select PYTHON3_MAKO > select PYTHON3_SIX > + select PYTHON3_SSL If so, append "if RUNTIME"? regards Philipp _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] piglit: add PYTHON3_SSL dependency 2020-11-19 11:35 ` Philipp Zabel @ 2020-11-19 11:47 ` Lucas Stach 2020-11-19 14:03 ` Roland Hieber 0 siblings, 1 reply; 5+ messages in thread From: Lucas Stach @ 2020-11-19 11:47 UTC (permalink / raw) To: ptxdist Am Donnerstag, den 19.11.2020, 12:35 +0100 schrieb Philipp Zabel: > On Thu, 2020-11-19 at 11:40 +0100, Lucas Stach wrote: > > Newer versions of the piglit runner require hashlib on the target. > > Is this a run-time only dependency? Yes, it is ... > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > --- > > rules/piglit.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/rules/piglit.in b/rules/piglit.in > > index c4414d545cc2..397585c5d26b 100644 > > --- a/rules/piglit.in > > +++ b/rules/piglit.in > > @@ -15,6 +15,7 @@ menuconfig PIGLIT > > select PYTHON3_LZMA > > select PYTHON3_MAKO > > select PYTHON3_SIX > > + select PYTHON3_SSL > > If so, append "if RUNTIME"? ... however SSL is a suboption of the python3 package, which is not a runtime only dependency, so adding "if RUNTIME" to this single option doesn't buy us anything, right? Regards, Lucas _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [PATCH] piglit: add PYTHON3_SSL dependency 2020-11-19 11:47 ` Lucas Stach @ 2020-11-19 14:03 ` Roland Hieber 0 siblings, 0 replies; 5+ messages in thread From: Roland Hieber @ 2020-11-19 14:03 UTC (permalink / raw) To: Lucas Stach; +Cc: ptxdist On Thu, Nov 19, 2020 at 12:47:26PM +0100, Lucas Stach wrote: > Am Donnerstag, den 19.11.2020, 12:35 +0100 schrieb Philipp Zabel: > > On Thu, 2020-11-19 at 11:40 +0100, Lucas Stach wrote: > > > Newer versions of the piglit runner require hashlib on the target. > > > > Is this a run-time only dependency? > > Yes, it is ... > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > > --- > > > rules/piglit.in | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/rules/piglit.in b/rules/piglit.in > > > index c4414d545cc2..397585c5d26b 100644 > > > --- a/rules/piglit.in > > > +++ b/rules/piglit.in > > > @@ -15,6 +15,7 @@ menuconfig PIGLIT > > > select PYTHON3_LZMA > > > select PYTHON3_MAKO > > > select PYTHON3_SIX > > > + select PYTHON3_SSL > > > > If so, append "if RUNTIME"? > > ... however SSL is a suboption of the python3 package, which is not a > runtime only dependency, so adding "if RUNTIME" to this single option > doesn't buy us anything, right? Only if you could also make python itself a runtime-only dependency, so in this case, you're right. - Roland -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ptxdist] [APPLIED] piglit: add PYTHON3_SSL dependency 2020-11-19 10:40 [ptxdist] [PATCH] piglit: add PYTHON3_SSL dependency Lucas Stach 2020-11-19 11:35 ` Philipp Zabel @ 2020-11-27 8:39 ` Michael Olbrich 1 sibling, 0 replies; 5+ messages in thread From: Michael Olbrich @ 2020-11-27 8:39 UTC (permalink / raw) To: ptxdist; +Cc: Lucas Stach Thanks, applied as abfa8116f37e1a180539f2d633fc06e1714ec4dd. Michael [sent from post-receive hook] On Fri, 27 Nov 2020 09:39:18 +0100, Lucas Stach <l.stach@pengutronix.de> wrote: > Newer versions of the piglit runner require hashlib on the target. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > Message-Id: <20201119104055.31981-1-l.stach@pengutronix.de> > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de> > > diff --git a/rules/piglit.in b/rules/piglit.in > index c4414d545cc2..397585c5d26b 100644 > --- a/rules/piglit.in > +++ b/rules/piglit.in > @@ -15,6 +15,7 @@ menuconfig PIGLIT > select PYTHON3_LZMA > select PYTHON3_MAKO > select PYTHON3_SIX > + select PYTHON3_SSL > select WAFFLE > select WAYLAND if PIGLIT_WAYLAND > select LIBXKBCOMMON if PIGLIT_WAYLAND _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-27 8:39 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-11-19 10:40 [ptxdist] [PATCH] piglit: add PYTHON3_SSL dependency Lucas Stach 2020-11-19 11:35 ` Philipp Zabel 2020-11-19 11:47 ` Lucas Stach 2020-11-19 14:03 ` Roland Hieber 2020-11-27 8:39 ` [ptxdist] [APPLIED] " Michael Olbrich
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox