* [ptxdist] [PATCH] binutils: add license information
@ 2020-04-16 8:43 Michael Tretter
2020-04-17 6:47 ` Michael Olbrich
0 siblings, 1 reply; 6+ messages in thread
From: Michael Tretter @ 2020-04-16 8:43 UTC (permalink / raw)
To: ptxdist; +Cc: Michael Tretter
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
rules/binutils.make | 1 +
1 file changed, 1 insertion(+)
diff --git a/rules/binutils.make b/rules/binutils.make
index ca1080bc811d..094347e3f8bf 100644
--- a/rules/binutils.make
+++ b/rules/binutils.make
@@ -22,6 +22,7 @@ BINUTILS_SUFFIX := tar.bz2
BINUTILS_URL := $(call ptx/mirror, GNU, binutils/$(BINUTILS).$(BINUTILS_SUFFIX))
BINUTILS_SOURCE := $(SRCDIR)/$(BINUTILS).$(BINUTILS_SUFFIX)
BINUTILS_DIR := $(BUILDDIR)/$(BINUTILS)
+BINUTILS_LICENSE := GPL-2.0-or-later AND GPL-3.0-or-later AND LGPL-2.0-or-later AND LGPL-3.0-or-later
# ----------------------------------------------------------------------------
# Prepare
--
2.20.1
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] binutils: add license information
2020-04-16 8:43 [ptxdist] [PATCH] binutils: add license information Michael Tretter
@ 2020-04-17 6:47 ` Michael Olbrich
2020-04-17 7:13 ` [ptxdist] [TOOLCHAIN PATCH] cross-binutils: export license for binutils package Michael Olbrich
2020-04-17 7:39 ` [ptxdist] [PATCH] binutils: add license information Michael Tretter
0 siblings, 2 replies; 6+ messages in thread
From: Michael Olbrich @ 2020-04-17 6:47 UTC (permalink / raw)
To: ptxdist; +Cc: Michael Tretter
On Thu, Apr 16, 2020 at 10:43:19AM +0200, Michael Tretter wrote:
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> rules/binutils.make | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/rules/binutils.make b/rules/binutils.make
> index ca1080bc811d..094347e3f8bf 100644
> --- a/rules/binutils.make
> +++ b/rules/binutils.make
> @@ -22,6 +22,7 @@ BINUTILS_SUFFIX := tar.bz2
> BINUTILS_URL := $(call ptx/mirror, GNU, binutils/$(BINUTILS).$(BINUTILS_SUFFIX))
> BINUTILS_SOURCE := $(SRCDIR)/$(BINUTILS).$(BINUTILS_SUFFIX)
> BINUTILS_DIR := $(BUILDDIR)/$(BINUTILS)
> +BINUTILS_LICENSE := GPL-2.0-or-later AND GPL-3.0-or-later AND LGPL-2.0-or-later AND LGPL-3.0-or-later
No. The version is derived from the toolchain, so we cannot be sure that
this is always correct. What we need to do is export the license
information in the toolchain and import it here when possible. We already
do the same thing for glibc and gcclibs.
Michael
>
> # ----------------------------------------------------------------------------
> # Prepare
> --
> 2.20.1
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ptxdist] [TOOLCHAIN PATCH] cross-binutils: export license for binutils package
2020-04-17 6:47 ` Michael Olbrich
@ 2020-04-17 7:13 ` Michael Olbrich
2020-04-17 7:39 ` [ptxdist] [PATCH] binutils: add license information Michael Tretter
1 sibling, 0 replies; 6+ messages in thread
From: Michael Olbrich @ 2020-04-17 7:13 UTC (permalink / raw)
To: ptxdist; +Cc: Michael Olbrich, Michael Tretter
The PTXdist binutils package gets its version from the toolchain. So it
always has the same version as the toolchain cross-binutils package.
Export the license data here, so it can be imported in the ptxdist package.
Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
---
Something like this I think. And then:
-include $(PTXDIST_PLATFORMDIR)/selected_toolchain/../share/compliance/binutils.make
in rules/binutils.make in PTXdist.
Michael
rules/cross-binutils.make | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/rules/cross-binutils.make b/rules/cross-binutils.make
index f29c2f821a02..2cdfdfc5d9a7 100644
--- a/rules/cross-binutils.make
+++ b/rules/cross-binutils.make
@@ -75,6 +75,13 @@ endif
@for bin in $(CROSS_BINUTILS_PKGDIR)$(PTXCONF_PREFIX_CROSS)/$(PTXCONF_GNU_TARGET)/bin/*; do \
ln -vsf ../../bin/$(COMPILER_PREFIX)$$(basename $${bin}) $${bin} || break; \
done
+
+ @$(call world/env, CROSS_BINUTILS) \
+ pkg_license_target=binutils \
+ pkg_license_target_license=$(PTXCONF_CROSS_BINUTILS_LICENSE) \
+ pkg_license_target_pattern=$(PTXCONF_CROSS_BINUTILS_LICENSES) \
+ ptxd_make_world_copy_license
+
@$(call touch)
$(STATEDIR)/cross-binutils.install.post:
--
2.20.1
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] binutils: add license information
2020-04-17 6:47 ` Michael Olbrich
2020-04-17 7:13 ` [ptxdist] [TOOLCHAIN PATCH] cross-binutils: export license for binutils package Michael Olbrich
@ 2020-04-17 7:39 ` Michael Tretter
2020-04-17 12:16 ` Roland Hieber
2020-04-17 12:23 ` Michael Olbrich
1 sibling, 2 replies; 6+ messages in thread
From: Michael Tretter @ 2020-04-17 7:39 UTC (permalink / raw)
To: ptxdist
On Fri, Apr 17, 2020 at 08:47:34AM +0200, Michael Olbrich wrote:
> On Thu, Apr 16, 2020 at 10:43:19AM +0200, Michael Tretter wrote:
> > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > ---
> > rules/binutils.make | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/rules/binutils.make b/rules/binutils.make
> > index ca1080bc811d..094347e3f8bf 100644
> > --- a/rules/binutils.make
> > +++ b/rules/binutils.make
> > @@ -22,6 +22,7 @@ BINUTILS_SUFFIX := tar.bz2
> > BINUTILS_URL := $(call ptx/mirror, GNU, binutils/$(BINUTILS).$(BINUTILS_SUFFIX))
> > BINUTILS_SOURCE := $(SRCDIR)/$(BINUTILS).$(BINUTILS_SUFFIX)
> > BINUTILS_DIR := $(BUILDDIR)/$(BINUTILS)
> > +BINUTILS_LICENSE := GPL-2.0-or-later AND GPL-3.0-or-later AND LGPL-2.0-or-later AND LGPL-3.0-or-later
>
> No. The version is derived from the toolchain, so we cannot be sure that
> this is always correct. What we need to do is export the license
> information in the toolchain and import it here when possible. We already
> do the same thing for glibc and gcclibs.
Hm. The difference between glibc/gcclibs and the binutils is that for binutils
only the version is extracted from the toolchain and the binutils are build
from source in the BSP. Thus, we could also extract the license information
from the downloaded source code, which would be the same license as in the
toolchain. I'm not sure if this is actually simpler than exporting the
license information in the toolchain.
Michael
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] binutils: add license information
2020-04-17 7:39 ` [ptxdist] [PATCH] binutils: add license information Michael Tretter
@ 2020-04-17 12:16 ` Roland Hieber
2020-04-17 12:23 ` Michael Olbrich
1 sibling, 0 replies; 6+ messages in thread
From: Roland Hieber @ 2020-04-17 12:16 UTC (permalink / raw)
To: ptxdist
On Fri, Apr 17, 2020 at 09:39:35AM +0200, Michael Tretter wrote:
> On Fri, Apr 17, 2020 at 08:47:34AM +0200, Michael Olbrich wrote:
> > On Thu, Apr 16, 2020 at 10:43:19AM +0200, Michael Tretter wrote:
> > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > > ---
> > > rules/binutils.make | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/rules/binutils.make b/rules/binutils.make
> > > index ca1080bc811d..094347e3f8bf 100644
> > > --- a/rules/binutils.make
> > > +++ b/rules/binutils.make
> > > @@ -22,6 +22,7 @@ BINUTILS_SUFFIX := tar.bz2
> > > BINUTILS_URL := $(call ptx/mirror, GNU, binutils/$(BINUTILS).$(BINUTILS_SUFFIX))
> > > BINUTILS_SOURCE := $(SRCDIR)/$(BINUTILS).$(BINUTILS_SUFFIX)
> > > BINUTILS_DIR := $(BUILDDIR)/$(BINUTILS)
> > > +BINUTILS_LICENSE := GPL-2.0-or-later AND GPL-3.0-or-later AND LGPL-2.0-or-later AND LGPL-3.0-or-later
> >
> > No. The version is derived from the toolchain, so we cannot be sure that
> > this is always correct. What we need to do is export the license
> > information in the toolchain and import it here when possible. We already
> > do the same thing for glibc and gcclibs.
>
> Hm. The difference between glibc/gcclibs and the binutils is that for binutils
> only the version is extracted from the toolchain and the binutils are build
> from source in the BSP. Thus, we could also extract the license information
> from the downloaded source code, which would be the same license as in the
> toolchain. I'm not sure if this is actually simpler than exporting the
> license information in the toolchain.
In any case, the respective _LICENSE_FILES variable should be set
somewhere too.
- Roland
--
Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [ptxdist] [PATCH] binutils: add license information
2020-04-17 7:39 ` [ptxdist] [PATCH] binutils: add license information Michael Tretter
2020-04-17 12:16 ` Roland Hieber
@ 2020-04-17 12:23 ` Michael Olbrich
1 sibling, 0 replies; 6+ messages in thread
From: Michael Olbrich @ 2020-04-17 12:23 UTC (permalink / raw)
To: ptxdist
On Fri, Apr 17, 2020 at 09:39:35AM +0200, Michael Tretter wrote:
> On Fri, Apr 17, 2020 at 08:47:34AM +0200, Michael Olbrich wrote:
> > On Thu, Apr 16, 2020 at 10:43:19AM +0200, Michael Tretter wrote:
> > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > > ---
> > > rules/binutils.make | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/rules/binutils.make b/rules/binutils.make
> > > index ca1080bc811d..094347e3f8bf 100644
> > > --- a/rules/binutils.make
> > > +++ b/rules/binutils.make
> > > @@ -22,6 +22,7 @@ BINUTILS_SUFFIX := tar.bz2
> > > BINUTILS_URL := $(call ptx/mirror, GNU, binutils/$(BINUTILS).$(BINUTILS_SUFFIX))
> > > BINUTILS_SOURCE := $(SRCDIR)/$(BINUTILS).$(BINUTILS_SUFFIX)
> > > BINUTILS_DIR := $(BUILDDIR)/$(BINUTILS)
> > > +BINUTILS_LICENSE := GPL-2.0-or-later AND GPL-3.0-or-later AND LGPL-2.0-or-later AND LGPL-3.0-or-later
> >
> > No. The version is derived from the toolchain, so we cannot be sure that
> > this is always correct. What we need to do is export the license
> > information in the toolchain and import it here when possible. We already
> > do the same thing for glibc and gcclibs.
>
> Hm. The difference between glibc/gcclibs and the binutils is that for binutils
> only the version is extracted from the toolchain and the binutils are build
> from source in the BSP. Thus, we could also extract the license information
> from the downloaded source code, which would be the same license as in the
> toolchain. I'm not sure if this is actually simpler than exporting the
> license information in the toolchain.
The point is, the version is only defined in the toolchain. So we cannot
add any fixed license information to ptxdist, because this may be correct
for all toolchains.
So the only way to make this work automatically is with help from the
toolchain.
Michael
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-17 12:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-16 8:43 [ptxdist] [PATCH] binutils: add license information Michael Tretter
2020-04-17 6:47 ` Michael Olbrich
2020-04-17 7:13 ` [ptxdist] [TOOLCHAIN PATCH] cross-binutils: export license for binutils package Michael Olbrich
2020-04-17 7:39 ` [ptxdist] [PATCH] binutils: add license information Michael Tretter
2020-04-17 12:16 ` Roland Hieber
2020-04-17 12:23 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox