From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28] helo=dude02.lab.pengutronix.de) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jPQ1d-0001Ve-KH for ptxdist@pengutronix.de; Fri, 17 Apr 2020 14:23:17 +0200 Received: from mol by dude02.lab.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1jPQ1d-0005vg-Bc for ptxdist@pengutronix.de; Fri, 17 Apr 2020 14:23:17 +0200 Date: Fri, 17 Apr 2020 14:23:17 +0200 From: Michael Olbrich Message-ID: <20200417122317.GI2081@pengutronix.de> References: <20200416084319.30304-1-m.tretter@pengutronix.de> <20200417064734.GH2081@pengutronix.de> <20200417073935.GA8984@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200417073935.GA8984@pengutronix.de> Subject: Re: [ptxdist] [PATCH] binutils: add license information List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ptxdist-bounces@pengutronix.de Sender: "ptxdist" To: ptxdist@pengutronix.de On Fri, Apr 17, 2020 at 09:39:35AM +0200, Michael Tretter wrote: > On Fri, Apr 17, 2020 at 08:47:34AM +0200, Michael Olbrich wrote: > > On Thu, Apr 16, 2020 at 10:43:19AM +0200, Michael Tretter wrote: > > > Signed-off-by: Michael Tretter > > > --- > > > rules/binutils.make | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/rules/binutils.make b/rules/binutils.make > > > index ca1080bc811d..094347e3f8bf 100644 > > > --- a/rules/binutils.make > > > +++ b/rules/binutils.make > > > @@ -22,6 +22,7 @@ BINUTILS_SUFFIX := tar.bz2 > > > BINUTILS_URL := $(call ptx/mirror, GNU, binutils/$(BINUTILS).$(BINUTILS_SUFFIX)) > > > BINUTILS_SOURCE := $(SRCDIR)/$(BINUTILS).$(BINUTILS_SUFFIX) > > > BINUTILS_DIR := $(BUILDDIR)/$(BINUTILS) > > > +BINUTILS_LICENSE := GPL-2.0-or-later AND GPL-3.0-or-later AND LGPL-2.0-or-later AND LGPL-3.0-or-later > > > > No. The version is derived from the toolchain, so we cannot be sure that > > this is always correct. What we need to do is export the license > > information in the toolchain and import it here when possible. We already > > do the same thing for glibc and gcclibs. > > Hm. The difference between glibc/gcclibs and the binutils is that for binutils > only the version is extracted from the toolchain and the binutils are build > from source in the BSP. Thus, we could also extract the license information > from the downloaded source code, which would be the same license as in the > toolchain. I'm not sure if this is actually simpler than exporting the > license information in the toolchain. The point is, the version is only defined in the toolchain. So we cannot add any fixed license information to ptxdist, because this may be correct for all toolchains. So the only way to make this work automatically is with help from the toolchain. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de