Re: [ptxdist] [PATCH 5/6] modemmanager: Add license file hashes

[Alexander Dahl <ada@thorsis.com>]

Hello Roland,

> Roland Hieber <rhi@pengutronix.de> hat am 24.03.2021 21:31 geschrieben:
> 
>  
> On Wed, Mar 24, 2021 at 07:35:39AM +0100, Alexander Dahl wrote:
> > From: Alexander Dahl <ada@thorsis.com>
> > 
> > Signed-off-by: Alexander Dahl <ada@thorsis.com>
> > ---
> >  rules/modemmanager.make | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/rules/modemmanager.make b/rules/modemmanager.make
> > index 09b3bc422..397a32850 100644
> > --- a/rules/modemmanager.make
> > +++ b/rules/modemmanager.make
> > @@ -22,6 +22,9 @@ MODEMMANAGER_URL	:= https://www.freedesktop.org/software/ModemManager/$(MODEMMAN
> >  MODEMMANAGER_SOURCE	:= $(SRCDIR)/$(MODEMMANAGER).$(MODEMMANAGER_SUFFIX)
> >  MODEMMANAGER_DIR	:= $(BUILDDIR)/$(MODEMMANAGER)
> >  MODEMMANAGER_LICENSE	:= GPL-2.0-or-later AND GPL-3.0-or-later AND LGPL-2.1-or-later
> > +MODEMMANAGER_LICENSE_FILES := \
> > +	file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
> > +	file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c
> 
> Did you find anything for GPL-3.0-or-later? The only files I could find
> were config.sub, ltmain.sh and config.guess, which are generated code,
> and won't make it into the binary at all.

There is also gtk-doc.make but the same applies for that.

> The ChangeLog mentions [1] something in 2015 about mmcli being wrongly
> attributed as GPLv3, although it has always been GPL-2.0-or-later.
> So I guess we could get rid of the "GPL-3.0-or-later" part in the
> license expression.
> 
> [1]: https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/commit/ee85a463cf806cd01a61587520245a4818ab1fbb

Agreed. I will add an additional patch to v2 of the series. I think we can tag that as fix for 9e22636e4ffd ("ModemManager: version bump 1.4.14 -> 1.6.0") then.

Greets
Alex

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de