Re: [ptxdist] [PATCH 3/6] libqmi: Add license file hashes

[Alexander Dahl <ada@thorsis.com>]

Hello Roland,

> Roland Hieber <rhi@pengutronix.de> hat am 24.03.2021 21:45 geschrieben:
> 
>  
> On Wed, Mar 24, 2021 at 07:35:37AM +0100, Alexander Dahl wrote:
> > From: Alexander Dahl <ada@thorsis.com>
> > 
> > Signed-off-by: Alexander Dahl <ada@thorsis.com>
> > ---
> >  rules/libqmi.make | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/rules/libqmi.make b/rules/libqmi.make
> > index 2b3e40140..3342eed20 100644
> > --- a/rules/libqmi.make
> > +++ b/rules/libqmi.make
> > @@ -22,6 +22,9 @@ LIBQMI_URL	:= http://www.freedesktop.org/software/libqmi/$(LIBQMI).$(LIBQMI_SUFF
> >  LIBQMI_SOURCE	:= $(SRCDIR)/$(LIBQMI).$(LIBQMI_SUFFIX)
> >  LIBQMI_DIR	:= $(BUILDDIR)/$(LIBQMI)
> >  LIBQMI_LICENSE	:= GPL-2.0-or-later AND LGPL-2.1-or-later
> > +LIBQMI_LICENSE_FILES := \
> > +	file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
> > +	file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c
> 
> Same here, someone seems to have copied the wrong license. Files in
> src/libqmi-glib/ and src/libqrtr-glib/ carry LGPL-2.0-or-later headers,
> and the README says that too. I didn't mention this in my previous mail,
> but I would rather not include COPYING.LIB then, and add a short comment
> why it isn't in there.

I'm not sure about this one. File headers say "Lesser GPL". The original LGPL 2.0 said "Library GPL". Looks to me like someone wanted 2.1 already, also in file headers. 

Should we also open a ticket at upstream to request clarification? That would be here in this case:

https://gitlab.freedesktop.org/mobile-broadband/libqmi

(It's a different maintainer than for libgudev btw.)

Greets
Alex

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de