Re: [ptxdist] [PATCH v2 3/3] lvm2: add bash as dependency

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Jul 03, 2026 at 10:33:36AM +0200, Sven Püschel wrote:
> Add bash as a dependency, as the fsadm and lvmdump tools are bash
> shell scripts.
> 
> Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
> 
> ---
> v2
> - added
> ---
>  rules/lvm2.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/rules/lvm2.in b/rules/lvm2.in
> index 032ed5006..8a6b26927 100644
> --- a/rules/lvm2.in
> +++ b/rules/lvm2.in
> @@ -9,6 +9,7 @@ menuconfig LVM2
>  	select NCURSES
>  	select SYSTEMD			if LVM2_SYSTEMD
>  	select LVM2_LIBDEVMAPPER_EVENT	if LVM2_LVM_TOOLS
> +	select BASH			if LVM2_LVM_TOOLS

No. Most tools don't need this and bash is quite big. Split this into a
separate option. And add '&& RUNTIME' to the condition.

Michael

>  	prompt "lvm2                          "
>  	help
>  	  LVM2 refers to a new userspace toolset that provide logical volume management
> -- 
> 2.47.3
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |