Re: [ptxdist] [PATCH v2 2/3] lvm2: add option for libdevmapper-event.so

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Jul 03, 2026 at 10:33:35AM +0200, Sven Püschel wrote:
> Add an option for libdevmapper-event.so, as it's not required by
> dmsetup. This allows omitting the library, if it's not being used by
> any other application on the system.
> 
> Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
> 
> ---
> v2
> - move select to LVM2 and add if condition

The rule for adding the 'select' to the main symbol is for external
dependencies. So I moved this back while appying.

Michael

> - remove redundant 'default n'
> ---
>  rules/lvm2.in   | 5 +++++
>  rules/lvm2.make | 3 +++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/rules/lvm2.in b/rules/lvm2.in
> index db009f8d5..032ed5006 100644
> --- a/rules/lvm2.in
> +++ b/rules/lvm2.in
> @@ -8,6 +8,7 @@ menuconfig LVM2
>  	select READLINE
>  	select NCURSES
>  	select SYSTEMD			if LVM2_SYSTEMD
> +	select LVM2_LIBDEVMAPPER_EVENT	if LVM2_LVM_TOOLS
>  	prompt "lvm2                          "
>  	help
>  	  LVM2 refers to a new userspace toolset that provide logical volume management
> @@ -33,6 +34,10 @@ config LVM2_STARTSCRIPT
>  
>  endif
>  
> +config LVM2_LIBDEVMAPPER_EVENT
> +	bool
> +	prompt "install libdevmapper-event.so"
> +
>  config LVM2_DEVICE_UID
>  	int
>  	default 0
> diff --git a/rules/lvm2.make b/rules/lvm2.make
> index d45c89356..57773a1f7 100644
> --- a/rules/lvm2.make
> +++ b/rules/lvm2.make
> @@ -163,7 +163,10 @@ ifdef PTXCONF_LVM2_LVM_TOOLS
>  endif
>  
>  	@$(call install_lib, lvm2, 0, 0, 0644, libdevmapper)
> +
> +ifdef PTXCONF_LVM2_LIBDEVMAPPER_EVENT
>  	@$(call install_lib, lvm2, 0, 0, 0644, libdevmapper-event)
> +endif
>  
>  ifdef PTXCONF_LVM2_STARTSCRIPT
>  	@$(call install_alternative, lvm2, 0, 0, 0755, /etc/init.d/lvm2)
> -- 
> 2.47.3
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |