Re: [ptxdist] [PATCH] udev-legacy: fix building with gcc 15

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

So, I don't mind applying this patch. But this stuff is really old. I've
not used this in a long time (all my BSPs use systemd) but if you really
want to continue without that, then I suggest, that udev from systemd
should be used.
Basically use the systemd sources and just install the udev parts.
I'm not going to do this myself, but I would review and merge patches that
go this way.

Michael

On Tue, Apr 14, 2026 at 10:57:02AM +0200, Andreas Helmcke wrote:
> Added missing function declaration for udev_builtin_validate
> 
> Signed-off-by: Andreas Helmcke <ahelmcke@ela-soft.com>
> ---
>  ...recent-gcc-added-missing-function-de.patch | 21 +++++++++++++++++++
>  patches/udev-182/series                       |  3 ++-
>  2 files changed, 23 insertions(+), 1 deletion(-)
>  create mode 100644 patches/udev-182/0004-Fix-build-witch-recent-gcc-added-missing-function-de.patch
> 
> diff --git a/patches/udev-182/0004-Fix-build-witch-recent-gcc-added-missing-function-de.patch b/patches/udev-182/0004-Fix-build-witch-recent-gcc-added-missing-function-de.patch
> new file mode 100644
> index 000000000..59f1653dc
> --- /dev/null
> +++ b/patches/udev-182/0004-Fix-build-witch-recent-gcc-added-missing-function-de.patch
> @@ -0,0 +1,21 @@
> +From: Andreas Helmcke <ahelmcke@ela-soft.com>
> +Date: Mon, 13 Apr 2026 13:34:09 +0200
> +Subject: [PATCH] Fix build witch recent gcc, added missing function
> + declaration
> +
> +---
> + src/udev.h | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/src/udev.h b/src/udev.h
> +index bc051c9b6574..ecf8cc5fe367 100644
> +--- a/src/udev.h
> ++++ b/src/udev.h
> +@@ -164,6 +164,7 @@ const char *udev_builtin_name(enum udev_builtin_cmd cmd);
> + bool udev_builtin_run_once(enum udev_builtin_cmd cmd);
> + int udev_builtin_run(struct udev_device *dev, enum udev_builtin_cmd cmd, const char *command, bool test);
> + void udev_builtin_list(struct udev *udev);
> ++bool udev_builtin_validate(struct udev *udev);
> + int udev_builtin_add_property(struct udev_device *dev, bool test, const char *key, const char *val);
> + 
> + /* udev logging */
> diff --git a/patches/udev-182/series b/patches/udev-182/series
> index 92ee4017b..ce4dbf817 100644
> --- a/patches/udev-182/series
> +++ b/patches/udev-182/series
> @@ -3,4 +3,5 @@
>  0001-configure.ac-fix-FTBFS-with-new-glibc.patch
>  0002-mtd-probe-fix-compilation.patch
>  0003-Fix-build-with-recent-glibc-releases.patch
> -# 1ac211f09adebb5f2f0678a4eda965d9  - git-ptx-patches magic
> +0004-Fix-build-witch-recent-gcc-added-missing-function-de.patch
> +# b21bf1430bf2663ce271b3b972fbf2e5  - git-ptx-patches magic
> -- 
> 2.51.0
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |