From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 15 Apr 2026 12:22:39 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wCxOJ-00CNdc-0f for lore@lore.pengutronix.de; Wed, 15 Apr 2026 12:22:39 +0200 Received: from [127.0.0.1] (helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1wCxOJ-00078L-2H; Wed, 15 Apr 2026 12:22:39 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1wCxOB-00077F-Rs; Wed, 15 Apr 2026 12:22:31 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wCxOB-005Umt-2B; Wed, 15 Apr 2026 12:22:31 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1wCxOB-0000000FGcT-2bcs; Wed, 15 Apr 2026 12:22:31 +0200 Date: Wed, 15 Apr 2026 12:22:31 +0200 From: Michael Olbrich To: Andreas Helmcke Message-ID: References: <20260414085702.11853-1-ahelmcke@ela-soft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260414085702.11853-1-ahelmcke@ela-soft.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] udev-legacy: fix building with gcc 15 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hi, So, I don't mind applying this patch. But this stuff is really old. I've not used this in a long time (all my BSPs use systemd) but if you really want to continue without that, then I suggest, that udev from systemd should be used. Basically use the systemd sources and just install the udev parts. I'm not going to do this myself, but I would review and merge patches that go this way. Michael On Tue, Apr 14, 2026 at 10:57:02AM +0200, Andreas Helmcke wrote: > Added missing function declaration for udev_builtin_validate > > Signed-off-by: Andreas Helmcke > --- > ...recent-gcc-added-missing-function-de.patch | 21 +++++++++++++++++++ > patches/udev-182/series | 3 ++- > 2 files changed, 23 insertions(+), 1 deletion(-) > create mode 100644 patches/udev-182/0004-Fix-build-witch-recent-gcc-added-missing-function-de.patch > > diff --git a/patches/udev-182/0004-Fix-build-witch-recent-gcc-added-missing-function-de.patch b/patches/udev-182/0004-Fix-build-witch-recent-gcc-added-missing-function-de.patch > new file mode 100644 > index 000000000..59f1653dc > --- /dev/null > +++ b/patches/udev-182/0004-Fix-build-witch-recent-gcc-added-missing-function-de.patch > @@ -0,0 +1,21 @@ > +From: Andreas Helmcke > +Date: Mon, 13 Apr 2026 13:34:09 +0200 > +Subject: [PATCH] Fix build witch recent gcc, added missing function > + declaration > + > +--- > + src/udev.h | 1 + > + 1 file changed, 1 insertion(+) > + > +diff --git a/src/udev.h b/src/udev.h > +index bc051c9b6574..ecf8cc5fe367 100644 > +--- a/src/udev.h > ++++ b/src/udev.h > +@@ -164,6 +164,7 @@ const char *udev_builtin_name(enum udev_builtin_cmd cmd); > + bool udev_builtin_run_once(enum udev_builtin_cmd cmd); > + int udev_builtin_run(struct udev_device *dev, enum udev_builtin_cmd cmd, const char *command, bool test); > + void udev_builtin_list(struct udev *udev); > ++bool udev_builtin_validate(struct udev *udev); > + int udev_builtin_add_property(struct udev_device *dev, bool test, const char *key, const char *val); > + > + /* udev logging */ > diff --git a/patches/udev-182/series b/patches/udev-182/series > index 92ee4017b..ce4dbf817 100644 > --- a/patches/udev-182/series > +++ b/patches/udev-182/series > @@ -3,4 +3,5 @@ > 0001-configure.ac-fix-FTBFS-with-new-glibc.patch > 0002-mtd-probe-fix-compilation.patch > 0003-Fix-build-with-recent-glibc-releases.patch > -# 1ac211f09adebb5f2f0678a4eda965d9 - git-ptx-patches magic > +0004-Fix-build-witch-recent-gcc-added-missing-function-de.patch > +# b21bf1430bf2663ce271b3b972fbf2e5 - git-ptx-patches magic > -- > 2.51.0 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |