Re: [ptxdist] [PATCH 07/20] figlet: replace URL with HTTPS

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Jun 12, 2024 at 02:32:59PM +0200, Alexander Dahl wrote:
> Hei hei,
> 
> sorry for being late to the party, but we just discussed this in IRC …
> 
> Am Tue, May 14, 2024 at 10:35:39PM +0200 schrieb Lucas Stach:
> > As the figlet page only provides FTP downloads, point the download
> > URL to the github repository of the maintainer, which is also linked
> > from the homepage.
> > 
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> >  rules/figlet.make | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/rules/figlet.make b/rules/figlet.make
> > index 3dad77154430..c6d2fb38ea06 100644
> > --- a/rules/figlet.make
> > +++ b/rules/figlet.make
> > @@ -20,7 +20,7 @@ FIGLET_VERSION		:= 2.2.5
> >  FIGLET_MD5		:= d88cb33a14f1469fff975d021ae2858e
> >  FIGLET			:= figlet-$(FIGLET_VERSION)
> >  FIGLET_SUFFIX		:= tar.gz
> > -FIGLET_URL		:= ftp://ftp.figlet.org/pub/figlet/program/unix/$(FIGLET).$(FIGLET_SUFFIX)
> > +FIGLET_URL		:= https://github.com/cmatsuoka/figlet/archive/refs/tags/$(FIGLET_VERSION).$(FIGLET_SUFFIX)
> 
> This is replacing a probably handcrafted tarball from 10+ years ago
> with a machine generated tarball from today.  Although the content
> looks similar, the md5sum is not the same.
> 
> What about using this instead?
> 
> http://ftp.figlet.org/pub/figlet/program/unix/figlet-2.2.5.tar.gz

For the record: I decided to add the md5sum for the new tarball instead.

Michael

> >  FIGLET_SOURCE		:= $(SRCDIR)/$(FIGLET).$(FIGLET_SUFFIX)
> >  FIGLET_DIR		:= $(BUILDDIR)/$(FIGLET)
> >  FIGLET_LICENSE		:= BSD-3-clause
> > -- 
> > 2.39.2
> > 
> > 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |