From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 13 Jun 2024 10:06:11 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sHfTH-005G9z-1h for lore@lore.pengutronix.de; Thu, 13 Jun 2024 10:06:11 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sHfTH-000248-4l; Thu, 13 Jun 2024 10:06:11 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHfSx-00023k-Od; Thu, 13 Jun 2024 10:05:51 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sHfSx-001yxk-Ab; Thu, 13 Jun 2024 10:05:51 +0200 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sHfSx-008PBX-0o; Thu, 13 Jun 2024 10:05:51 +0200 Date: Thu, 13 Jun 2024 10:05:51 +0200 From: Michael Olbrich To: Lucas Stach , ptxdist@pengutronix.de Message-ID: Mail-Followup-To: Lucas Stach , ptxdist@pengutronix.de References: <20240514203552.1297323-1-l.stach@pengutronix.de> <20240514203552.1297323-8-l.stach@pengutronix.de> <20240612-undead-remover-b8858c6675ad@thorsis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240612-undead-remover-b8858c6675ad@thorsis.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-IRC: #ptxdist @freenode Subject: Re: [ptxdist] [PATCH 07/20] figlet: replace URL with HTTPS X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Wed, Jun 12, 2024 at 02:32:59PM +0200, Alexander Dahl wrote: > Hei hei, > > sorry for being late to the party, but we just discussed this in IRC … > > Am Tue, May 14, 2024 at 10:35:39PM +0200 schrieb Lucas Stach: > > As the figlet page only provides FTP downloads, point the download > > URL to the github repository of the maintainer, which is also linked > > from the homepage. > > > > Signed-off-by: Lucas Stach > > --- > > rules/figlet.make | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/rules/figlet.make b/rules/figlet.make > > index 3dad77154430..c6d2fb38ea06 100644 > > --- a/rules/figlet.make > > +++ b/rules/figlet.make > > @@ -20,7 +20,7 @@ FIGLET_VERSION := 2.2.5 > > FIGLET_MD5 := d88cb33a14f1469fff975d021ae2858e > > FIGLET := figlet-$(FIGLET_VERSION) > > FIGLET_SUFFIX := tar.gz > > -FIGLET_URL := ftp://ftp.figlet.org/pub/figlet/program/unix/$(FIGLET).$(FIGLET_SUFFIX) > > +FIGLET_URL := https://github.com/cmatsuoka/figlet/archive/refs/tags/$(FIGLET_VERSION).$(FIGLET_SUFFIX) > > This is replacing a probably handcrafted tarball from 10+ years ago > with a machine generated tarball from today. Although the content > looks similar, the md5sum is not the same. > > What about using this instead? > > http://ftp.figlet.org/pub/figlet/program/unix/figlet-2.2.5.tar.gz For the record: I decided to add the md5sum for the new tarball instead. Michael > > FIGLET_SOURCE := $(SRCDIR)/$(FIGLET).$(FIGLET_SUFFIX) > > FIGLET_DIR := $(BUILDDIR)/$(FIGLET) > > FIGLET_LICENSE := BSD-3-clause > > -- > > 2.39.2 > > > > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |