Re: [ptxdist] [PATCH] libtracefs: fix license and add license files

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Jan 10, 2025 at 11:43:58AM +0100, Roland Hieber wrote:
> While the source includes a GPL-2.0 license text, this license is only
> used for the build scripts, and does not make it into the binary.  The
> Bison-generated parser code is licensed under GPL-3.0-or-later with a
> license exception allowing it (in this case) to be released under
> a different license. The resulting binary is under LGPL-2.1-or-later (as
> mentioned in the original mail thread it uses the old SPDX identifiers).
> 
> Link: https://lore.ptxdist.org/ptxdist/Z4DbKik6UoE956Sq@pengutronix.de
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  rules/libtracefs.make | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/libtracefs.make b/rules/libtracefs.make
> index 12f0c6e7972c..21c30d95fc61 100644
> --- a/rules/libtracefs.make
> +++ b/rules/libtracefs.make
> @@ -21,7 +21,12 @@ LIBTRACEFS_SUFFIX	:= tar.xz
>  LIBTRACEFS_URL		:= https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git;tag=libtracefs-$(LIBTRACEFS_VERSION)
>  LIBTRACEFS_SOURCE	:= $(SRCDIR)/$(LIBTRACEFS).$(LIBTRACEFS_SUFFIX)
>  LIBTRACEFS_DIR		:= $(BUILDDIR)/$(LIBTRACEFS)
> -LIBTRACEFS_LICENSE	:= LGPL-2.1 + GPL-2.0

I've updated this to the new identifiers, but did not remove the GPL-2.0.
Please rebase.

> +LIBTRACEFS_LICENSE	:= LGPL-2.1-only AND GPL-3.0-or-later WITH custom-exception

I'm pretty sure that the exception is not a custom one. Looks like
Bison-exception-2.2 to me.

> +LIBTRACEFS_LICENSE_FILES	:= \
> +	file://src/tracefs-utils.c;startline=0;endline=8;md5=c6bedd276596b669012b69e9317ffade \

I get an error for startline=0 but startline=1 works with the md5?!?

Michael

> +	file://src/sqlhist.tab.c;startline=3;endline=32;md5=67ac50d80b3ebb72edad40dafe30d75e \
> +	file://LICENSES/LGPL-2.1;md5=b370887980db5dd40659b50909238dbd
> +# note: source includes a LICENSES/GPL-2.0, but it's only used in build scripts
>  
>  # ----------------------------------------------------------------------------
>  # Prepare
> -- 
> 2.39.5
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |