Re: [ptxdist] [PATCH 2/3] libtracefs: new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Jan 08, 2025 at 11:09:52AM +0100, Roland Hieber wrote:
> On Tue, Dec 10, 2024 at 11:56:28AM +0100, Lucas Stach wrote:
> > Linux kernel trace filesystem library, which has been
> > split out from trace-cmd and kernelshark.
> > 
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> >  rules/libtracefs.in   |  9 +++++++
> >  rules/libtracefs.make | 59 +++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 68 insertions(+)
> >  create mode 100644 rules/libtracefs.in
> >  create mode 100644 rules/libtracefs.make
> > 
> > diff --git a/rules/libtracefs.in b/rules/libtracefs.in
> > new file mode 100644
> > index 000000000000..0f1793a5ee96
> > --- /dev/null
> > +++ b/rules/libtracefs.in
> > @@ -0,0 +1,9 @@
> > +## SECTION=system_libraries
> > +
> > +config LIBTRACEFS
> > +	tristate
> > +	select HOST_MESON
> > +	select LIBTRACEEVENT
> > +	prompt "libtracefs"
> > +	help
> > +	  Linux kernel trace filesystem library
> > diff --git a/rules/libtracefs.make b/rules/libtracefs.make
> > new file mode 100644
> > index 000000000000..12f0c6e7972c
> > --- /dev/null
> > +++ b/rules/libtracefs.make
> > @@ -0,0 +1,59 @@
> > +# -*-makefile-*-
> > +#
> > +# Copyright (C) 2024 by Lucas Stach <l.stach@pengutronix.de>
> > +#
> > +# For further information about the PTXdist project and license conditions
> > +# see the README file.
> > +#
> > +
> > +#
> > +# We provide this package
> > +#
> > +PACKAGES-$(PTXCONF_LIBTRACEFS) += libtracefs
> > +
> > +#
> > +# Paths and names
> > +#
> > +LIBTRACEFS_VERSION	:= 1.8.1
> > +LIBTRACEFS_MD5		:= d16612bef28cb49e898558fe362496cc
> > +LIBTRACEFS		:= libtracefs-$(LIBTRACEFS_VERSION)
> > +LIBTRACEFS_SUFFIX	:= tar.xz
> > +LIBTRACEFS_URL		:= https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git;tag=libtracefs-$(LIBTRACEFS_VERSION)
> > +LIBTRACEFS_SOURCE	:= $(SRCDIR)/$(LIBTRACEFS).$(LIBTRACEFS_SUFFIX)
> > +LIBTRACEFS_DIR		:= $(BUILDDIR)/$(LIBTRACEFS)
> > +LIBTRACEFS_LICENSE	:= LGPL-2.1 + GPL-2.0
> 
> Correct SPDX syntax is AND instead of +. Also you need to choose between
> -or-later and -only versions for both licenses. And fill
> LIBTRACEFS_LICENSE_FILES.

Right, I missed that when I applied the patch. The SPDX identifiers here
are the old syntax, so "LGPL-2.1-only AND GPL-2.0-only" is correct. I'll
fix it.

Michael

>  - Roland
> 
> > +
> > +# ----------------------------------------------------------------------------
> > +# Prepare
> > +# ----------------------------------------------------------------------------
> > +
> > +#
> > +# meson
> > +#
> > +LIBTRACEFS_CONF_TOOL	:= meson
> > +LIBTRACEFS_CONF_OPT	:=  \
> > +	$(CROSS_MESON_USR) \
> > +	-Ddoc=false \
> > +	-Dsamples=false \
> > +	-Dutest=false
> > +
> > +# ----------------------------------------------------------------------------
> > +# Target-Install
> > +# ----------------------------------------------------------------------------
> > +
> > +$(STATEDIR)/libtracefs.targetinstall:
> > +	@$(call targetinfo)
> > +
> > +	@$(call install_init, libtracefs)
> > +	@$(call install_fixup, libtracefs,PRIORITY,optional)
> > +	@$(call install_fixup, libtracefs,SECTION,base)
> > +	@$(call install_fixup, libtracefs,AUTHOR,"Lucas Stach <l.stach@pengutronix.de>")
> > +	@$(call install_fixup, libtracefs,DESCRIPTION,missing)
> > +
> > +	@$(call install_lib, libtracefs, 0, 0, 0644, libtracefs)
> > +
> > +	@$(call install_finish, libtracefs)
> > +
> > +	@$(call touch)
> > +
> > +# vim: syntax=make
> > -- 
> > 2.39.5
> > 
> > 
> > 
> 
> -- 
> Roland Hieber, Pengutronix e.K.          | rhi@pengutronix.de          |
> Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
> 31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |