mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Christian Melki <christian.melki@t2data.com>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] u-boot.in: Move host openssl select.
Date: Fri, 18 Feb 2022 16:15:24 +0100	[thread overview]
Message-ID: <Yg+4DB74eJxYGam0@pengutronix.de> (raw)
In-Reply-To: <20220218090742.324777-1-christian.melki@t2data.com>

On Fri, Feb 18, 2022 at 10:07:42AM +0100, Christian Melki wrote:
> Minor cosmetic fix.
> 
> Host openssl selection was confusingly last under the
> "target" divider. I missed it at first in menuconfig,
> before realizing where it was.

Hmmm, still confusing I think. Maybe with a "build dependencies" divider
instead, or in addition?

Michael

> Signed-off-by: Christian Melki <christian.melki@t2data.com>
> ---
>  platforms/u-boot.in | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/platforms/u-boot.in b/platforms/u-boot.in
> index 6589a1940..0d7608ab3 100644
> --- a/platforms/u-boot.in
> +++ b/platforms/u-boot.in
> @@ -168,6 +168,18 @@ config U_BOOT_BOOT_SCRIPT_ROOTFS_PATH
>  
>  endif
>  
> +config U_BOOT_NEEDS_HOST_OPENSSL
> +	prompt "needs host OpenSSL"
> +	bool
> +	help
> +	  Newer host U-Boot tools can sign images and use OpenSSL for that.
> +	  It is most probably needed if your board config does not disable
> +	  CONFIG_TOOLS_LIBCRYPTO.
> +	
> +	  Select this if you're unsure, as it won't hurt.
> +	  It might just increase the build time, if no other package has
> +	  host openssl selected.
> +
>  comment "target install"
>  
>  config U_BOOT_INSTALL_SREC
> @@ -258,17 +270,5 @@ config U_BOOT_INSTALL_U_BOOT_STM32
>  	  platform image directory. Say yes if you are building for STM32MP1
>  	  SOCs.
>  
> -config U_BOOT_NEEDS_HOST_OPENSSL
> -	prompt "needs host OpenSSL"
> -	bool
> -	help
> -	  Newer host U-Boot tools can sign images and use OpenSSL for that.
> -	  It is most probably needed if your board config does not disable
> -	  CONFIG_TOOLS_LIBCRYPTO.
> -	
> -	  Select this if you're unsure, as it won't hurt.
> -	  It might just increase the build time, if no other package has
> -	  host openssl selected.
> -
>  endif
>  
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de


  reply	other threads:[~2022-02-18 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18  9:07 Christian Melki
2022-02-18 15:15 ` Michael Olbrich [this message]
2022-02-18 15:15   ` Christian Melki
2022-02-18 15:43     ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yg+4DB74eJxYGam0@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=christian.melki@t2data.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox