Re: [ptxdist] [PATCH] u-boot.in: Move host openssl select.

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Feb 18, 2022 at 04:15:29PM +0100, Christian Melki wrote:
> Build dependencies works for me.
> Move back to original position?

The old position would match barebox (that could use a divider as well...)
but I don't really care.

Michael

> On 2/18/22 4:15 PM, Michael Olbrich wrote:
> > On Fri, Feb 18, 2022 at 10:07:42AM +0100, Christian Melki wrote:
> > > Minor cosmetic fix.
> > > 
> > > Host openssl selection was confusingly last under the
> > > "target" divider. I missed it at first in menuconfig,
> > > before realizing where it was.
> > 
> > Hmmm, still confusing I think. Maybe with a "build dependencies" divider
> > instead, or in addition?
> > 
> > Michael
> > 
> > > Signed-off-by: Christian Melki <christian.melki@t2data.com>
> > > ---
> > >   platforms/u-boot.in | 24 ++++++++++++------------
> > >   1 file changed, 12 insertions(+), 12 deletions(-)
> > > 
> > > diff --git a/platforms/u-boot.in b/platforms/u-boot.in
> > > index 6589a1940..0d7608ab3 100644
> > > --- a/platforms/u-boot.in
> > > +++ b/platforms/u-boot.in
> > > @@ -168,6 +168,18 @@ config U_BOOT_BOOT_SCRIPT_ROOTFS_PATH
> > >   endif
> > > +config U_BOOT_NEEDS_HOST_OPENSSL
> > > +	prompt "needs host OpenSSL"
> > > +	bool
> > > +	help
> > > +	  Newer host U-Boot tools can sign images and use OpenSSL for that.
> > > +	  It is most probably needed if your board config does not disable
> > > +	  CONFIG_TOOLS_LIBCRYPTO.
> > > +	
> > > +	  Select this if you're unsure, as it won't hurt.
> > > +	  It might just increase the build time, if no other package has
> > > +	  host openssl selected.
> > > +
> > >   comment "target install"
> > >   config U_BOOT_INSTALL_SREC
> > > @@ -258,17 +270,5 @@ config U_BOOT_INSTALL_U_BOOT_STM32
> > >   	  platform image directory. Say yes if you are building for STM32MP1
> > >   	  SOCs.
> > > -config U_BOOT_NEEDS_HOST_OPENSSL
> > > -	prompt "needs host OpenSSL"
> > > -	bool
> > > -	help
> > > -	  Newer host U-Boot tools can sign images and use OpenSSL for that.
> > > -	  It is most probably needed if your board config does not disable
> > > -	  CONFIG_TOOLS_LIBCRYPTO.
> > > -	
> > > -	  Select this if you're unsure, as it won't hurt.
> > > -	  It might just increase the build time, if no other package has
> > > -	  host openssl selected.
> > > -
> > >   endif
> > > -- 
> > > 2.30.2
> > > 
> > > 
> > > _______________________________________________
> > > ptxdist mailing list
> > > ptxdist@pengutronix.de
> > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
> > > 
> > 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de