* [ptxdist] [PATCH] systemd: always install udev rule for kernel module loading
@ 2021-11-26 9:58 Bastian Krause
2021-11-26 14:33 ` Michael Olbrich
2021-11-29 13:50 ` [ptxdist] [APPLIED] " Michael Olbrich
0 siblings, 2 replies; 3+ messages in thread
From: Bastian Krause @ 2021-11-26 9:58 UTC (permalink / raw)
To: ptxdist; +Cc: Bastian Krause
It is generally intended that kernel modules are loaded via udev. So
drop the corresponding option and install the udev rule unconditionally.
Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
rules/systemd.in | 11 -----------
rules/systemd.make | 2 +-
2 files changed, 1 insertion(+), 12 deletions(-)
diff --git a/rules/systemd.in b/rules/systemd.in
index 74169cd5a..1a8696d2b 100644
--- a/rules/systemd.in
+++ b/rules/systemd.in
@@ -176,17 +176,6 @@ menu "udev "
menu "install options "
-config SYSTEMD_UDEV_DRIVERS_RULES
- bool
- default y
- prompt "install udev driver rules"
- help
- This will install the generic udev drivers rules files from the udev package
- under '/usr/lib/udev/rules.d/',
- These rules are required to automatically load kernel modules on
- udev start.
- If unsure say Y.
-
config SYSTEMD_UDEV_HWDB
bool
select SYSTEMD_HWDB
diff --git a/rules/systemd.make b/rules/systemd.make
index 2d96de70b..41bd5a8a8 100644
--- a/rules/systemd.make
+++ b/rules/systemd.make
@@ -299,6 +299,7 @@ SYSTEMD_UDEV_RULES-y := \
64-btrfs.rules \
75-net-description.rules \
78-sound-card.rules \
+ 80-drivers.rules \
80-net-setup-link.rules \
99-systemd.rules
@@ -323,7 +324,6 @@ SYSTEMD_UDEV_RULES-$(PTXCONF_SYSTEMD_UDEV_PERSISTENT_FIDO) += 60-fido-id.rules
SYSTEMD_UDEV_RULES-$(PTXCONF_SYSTEMD_UDEV_PERSISTENT_V4L) += 60-persistent-v4l.rules
SYSTEMD_UDEV_RULES-$(PTXCONF_ARCH_X86) += 70-memory.rules
SYSTEMD_UDEV_RULES-$(PTXCONF_SYSTEMD_UDEV_MTD_PROBE) += 75-probe_mtd.rules
-SYSTEMD_UDEV_RULES-$(PTXCONF_SYSTEMD_UDEV_DRIVERS_RULES) += 80-drivers.rules
$(STATEDIR)/systemd.targetinstall:
@$(call targetinfo)
--
2.30.2
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [PATCH] systemd: always install udev rule for kernel module loading
2021-11-26 9:58 [ptxdist] [PATCH] systemd: always install udev rule for kernel module loading Bastian Krause
@ 2021-11-26 14:33 ` Michael Olbrich
2021-11-29 13:50 ` [ptxdist] [APPLIED] " Michael Olbrich
1 sibling, 0 replies; 3+ messages in thread
From: Michael Olbrich @ 2021-11-26 14:33 UTC (permalink / raw)
To: Bastian Krause; +Cc: ptxdist
On Fri, Nov 26, 2021 at 10:58:00AM +0100, Bastian Krause wrote:
> It is generally intended that kernel modules are loaded via udev. So
> drop the corresponding option and install the udev rule unconditionally.
Right. Dropping this option probably makes sense. I've yet to find a
use-case where disabling this would be correct.
Michael
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> ---
> rules/systemd.in | 11 -----------
> rules/systemd.make | 2 +-
> 2 files changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/rules/systemd.in b/rules/systemd.in
> index 74169cd5a..1a8696d2b 100644
> --- a/rules/systemd.in
> +++ b/rules/systemd.in
> @@ -176,17 +176,6 @@ menu "udev "
>
> menu "install options "
>
> -config SYSTEMD_UDEV_DRIVERS_RULES
> - bool
> - default y
> - prompt "install udev driver rules"
> - help
> - This will install the generic udev drivers rules files from the udev package
> - under '/usr/lib/udev/rules.d/',
> - These rules are required to automatically load kernel modules on
> - udev start.
> - If unsure say Y.
> -
> config SYSTEMD_UDEV_HWDB
> bool
> select SYSTEMD_HWDB
> diff --git a/rules/systemd.make b/rules/systemd.make
> index 2d96de70b..41bd5a8a8 100644
> --- a/rules/systemd.make
> +++ b/rules/systemd.make
> @@ -299,6 +299,7 @@ SYSTEMD_UDEV_RULES-y := \
> 64-btrfs.rules \
> 75-net-description.rules \
> 78-sound-card.rules \
> + 80-drivers.rules \
> 80-net-setup-link.rules \
> 99-systemd.rules
>
> @@ -323,7 +324,6 @@ SYSTEMD_UDEV_RULES-$(PTXCONF_SYSTEMD_UDEV_PERSISTENT_FIDO) += 60-fido-id.rules
> SYSTEMD_UDEV_RULES-$(PTXCONF_SYSTEMD_UDEV_PERSISTENT_V4L) += 60-persistent-v4l.rules
> SYSTEMD_UDEV_RULES-$(PTXCONF_ARCH_X86) += 70-memory.rules
> SYSTEMD_UDEV_RULES-$(PTXCONF_SYSTEMD_UDEV_MTD_PROBE) += 75-probe_mtd.rules
> -SYSTEMD_UDEV_RULES-$(PTXCONF_SYSTEMD_UDEV_DRIVERS_RULES) += 80-drivers.rules
>
> $(STATEDIR)/systemd.targetinstall:
> @$(call targetinfo)
> --
> 2.30.2
>
>
> _______________________________________________
> ptxdist mailing list
> ptxdist@pengutronix.de
> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [APPLIED] systemd: always install udev rule for kernel module loading
2021-11-26 9:58 [ptxdist] [PATCH] systemd: always install udev rule for kernel module loading Bastian Krause
2021-11-26 14:33 ` Michael Olbrich
@ 2021-11-29 13:50 ` Michael Olbrich
1 sibling, 0 replies; 3+ messages in thread
From: Michael Olbrich @ 2021-11-29 13:50 UTC (permalink / raw)
To: ptxdist; +Cc: Bastian Krause
Thanks, applied as e85e463bb4164a5a68bb4ad06dfdb5d713a86448.
Michael
[sent from post-receive hook]
On Mon, 29 Nov 2021 14:50:57 +0100, Bastian Krause <bst@pengutronix.de> wrote:
> It is generally intended that kernel modules are loaded via udev. So
> drop the corresponding option and install the udev rule unconditionally.
>
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> Message-Id: <20211126095800.2374644-1-bst@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/systemd.in b/rules/systemd.in
> index 74169cd5a7ca..1a8696d2b821 100644
> --- a/rules/systemd.in
> +++ b/rules/systemd.in
> @@ -176,17 +176,6 @@ menu "udev "
>
> menu "install options "
>
> -config SYSTEMD_UDEV_DRIVERS_RULES
> - bool
> - default y
> - prompt "install udev driver rules"
> - help
> - This will install the generic udev drivers rules files from the udev package
> - under '/usr/lib/udev/rules.d/',
> - These rules are required to automatically load kernel modules on
> - udev start.
> - If unsure say Y.
> -
> config SYSTEMD_UDEV_HWDB
> bool
> select SYSTEMD_HWDB
> diff --git a/rules/systemd.make b/rules/systemd.make
> index 2d96de70b628..41bd5a8a8679 100644
> --- a/rules/systemd.make
> +++ b/rules/systemd.make
> @@ -299,6 +299,7 @@ SYSTEMD_UDEV_RULES-y := \
> 64-btrfs.rules \
> 75-net-description.rules \
> 78-sound-card.rules \
> + 80-drivers.rules \
> 80-net-setup-link.rules \
> 99-systemd.rules
>
> @@ -323,7 +324,6 @@ SYSTEMD_UDEV_RULES-$(PTXCONF_SYSTEMD_UDEV_PERSISTENT_FIDO) += 60-fido-id.rules
> SYSTEMD_UDEV_RULES-$(PTXCONF_SYSTEMD_UDEV_PERSISTENT_V4L) += 60-persistent-v4l.rules
> SYSTEMD_UDEV_RULES-$(PTXCONF_ARCH_X86) += 70-memory.rules
> SYSTEMD_UDEV_RULES-$(PTXCONF_SYSTEMD_UDEV_MTD_PROBE) += 75-probe_mtd.rules
> -SYSTEMD_UDEV_RULES-$(PTXCONF_SYSTEMD_UDEV_DRIVERS_RULES) += 80-drivers.rules
>
> $(STATEDIR)/systemd.targetinstall:
> @$(call targetinfo)
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-29 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-26 9:58 [ptxdist] [PATCH] systemd: always install udev rule for kernel module loading Bastian Krause
2021-11-26 14:33 ` Michael Olbrich
2021-11-29 13:50 ` [ptxdist] [APPLIED] " Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox