mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <mol@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Marco Felsch <m.felsch@pengutronix.de>
Subject: Re: [ptxdist] [APPLIED] wpewebkit: add runtime logging support
Date: Tue, 30 Mar 2021 20:08:09 +0200	[thread overview]
Message-ID: <E1lRImf-00HZ1r-Vt@dude03.red.stw.pengutronix.de> (raw)
In-Reply-To: <20210329090011.25309-4-m.felsch@pengutronix.de>

Thanks, applied as c3361e082f90ca37f6572a444c670eed08b6d266.

Michael

[sent from post-receive hook]

On Tue, 30 Mar 2021 20:08:09 +0200, Marco Felsch <m.felsch@pengutronix.de> wrote:
> To enable 'Release' builds with logging support we need to override the
> LOG_DISABLED define else logging is only enabled for 'Debug' builds.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> Message-Id: <20210329090011.25309-4-m.felsch@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/wpewebkit.in b/rules/wpewebkit.in
> index f123f4dad343..1235e2502047 100644
> --- a/rules/wpewebkit.in
> +++ b/rules/wpewebkit.in
> @@ -90,4 +90,11 @@ config WPEWEBKIT_AUDIO
>  	bool
>  	prompt "audio support"
>  
> +config WPEWEBKIT_ENABLE_LOGGING
> +	bool
> +	prompt "enable logging support"
> +	help
> +	  Enable this option if you want to get some more logging information. For more
> +	  information check https://trac.webkit.org/wiki/WebKitGTK/Debugging.
> +
>  endif
> diff --git a/rules/wpewebkit.make b/rules/wpewebkit.make
> index 9e41e322239c..141d83a71085 100644
> --- a/rules/wpewebkit.make
> +++ b/rules/wpewebkit.make
> @@ -76,6 +76,10 @@ WPEWEBKIT_CONF_OPT	+= \
>  	-DENABLE_REMOTE_INSPECTOR=ON \
>  	-DUSE_SYSTEM_MALLOC=$(WPEWEBKIT_SYSTEM_MALLOC)
>  
> +ifdef PTXCONF_WPEWEBKIT_ENABLE_LOGGING
> +WPEWEBKIT_CXXFLAGS	:= -DLOG_DISABLED=0
> +endif
> +
>  # ----------------------------------------------------------------------------
>  # Target-Install
>  # ----------------------------------------------------------------------------

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

  reply	other threads:[~2021-03-30 18:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-29  9:00 [ptxdist] [PATCH 1/4] wpewebkit: version bump 2.30.5 -> 2.30.6 Marco Felsch
2021-03-29  9:00 ` [ptxdist] [PATCH 2/4] wpebackend-fdo: version bump 1.8.1 -> 1.8.2 Marco Felsch
2021-03-30 18:08   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-03-29  9:00 ` [ptxdist] [PATCH 3/4] cog: version bump 0.8.0 -> 0.8.1 Marco Felsch
2021-03-30 18:08   ` [ptxdist] [APPLIED] " Michael Olbrich
2021-03-29  9:00 ` [ptxdist] [PATCH 4/4] wpewebkit: add runtime logging support Marco Felsch
2021-03-30 18:08   ` Michael Olbrich [this message]
2021-03-30 18:08 ` [ptxdist] [APPLIED] wpewebkit: version bump 2.30.5 -> 2.30.6 Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1lRImf-00HZ1r-Vt@dude03.red.stw.pengutronix.de \
    --to=mol@pengutronix.de \
    --cc=m.felsch@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox