From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
In-Reply-To: <20210329090011.25309-4-m.felsch@pengutronix.de>
MIME-Version: 1.0
Message-Id: <E1lRImf-00HZ1r-Vt@dude03.red.stw.pengutronix.de>
From: Michael Olbrich <mol@pengutronix.de>
Date: Tue, 30 Mar 2021 20:08:09 +0200
Subject: Re: [ptxdist] [APPLIED] wpewebkit: add runtime logging support
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ptxdist-bounces@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Marco Felsch <m.felsch@pengutronix.de>

Thanks, applied as c3361e082f90ca37f6572a444c670eed08b6d266.

Michael

[sent from post-receive hook]

On Tue, 30 Mar 2021 20:08:09 +0200, Marco Felsch <m.felsch@pengutronix.de> wrote:
> To enable 'Release' builds with logging support we need to override the
> LOG_DISABLED define else logging is only enabled for 'Debug' builds.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> Message-Id: <20210329090011.25309-4-m.felsch@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/wpewebkit.in b/rules/wpewebkit.in
> index f123f4dad343..1235e2502047 100644
> --- a/rules/wpewebkit.in
> +++ b/rules/wpewebkit.in
> @@ -90,4 +90,11 @@ config WPEWEBKIT_AUDIO
>  	bool
>  	prompt "audio support"
>  
> +config WPEWEBKIT_ENABLE_LOGGING
> +	bool
> +	prompt "enable logging support"
> +	help
> +	  Enable this option if you want to get some more logging information. For more
> +	  information check https://trac.webkit.org/wiki/WebKitGTK/Debugging.
> +
>  endif
> diff --git a/rules/wpewebkit.make b/rules/wpewebkit.make
> index 9e41e322239c..141d83a71085 100644
> --- a/rules/wpewebkit.make
> +++ b/rules/wpewebkit.make
> @@ -76,6 +76,10 @@ WPEWEBKIT_CONF_OPT	+= \
>  	-DENABLE_REMOTE_INSPECTOR=ON \
>  	-DUSE_SYSTEM_MALLOC=$(WPEWEBKIT_SYSTEM_MALLOC)
>  
> +ifdef PTXCONF_WPEWEBKIT_ENABLE_LOGGING
> +WPEWEBKIT_CXXFLAGS	:= -DLOG_DISABLED=0
> +endif
> +
>  # ----------------------------------------------------------------------------
>  # Target-Install
>  # ----------------------------------------------------------------------------

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de