From: Michael Olbrich <mol@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [APPLIED] nodejs_packages: Call yarn in the right environment
Date: Fri, 05 Mar 2021 08:26:17 +0100 [thread overview]
Message-ID: <E1lI4qn-000ANc-4X@dude03.red.stw.pengutronix.de> (raw)
In-Reply-To: <20210302094745.23210-1-s.hauer@pengutronix.de>
Thanks, applied as 7f86f698626c990e1d5750088d68bd7f0c993e70.
Michael
[sent from post-receive hook]
On Fri, 05 Mar 2021 08:26:17 +0100, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> Call yarn in node/env to actually cross compile native packages.
> Without it the host compiler is used and installation of native packages
> ends with something like:
>
> arm-v7a-linux-gnueabihf-strip: platform/packages/nodejs_packages-0.0.1/usr/lib/node_modules/epoll/build/Release/obj.target/epoll.node: file format not recognized
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Message-Id: <20210302094745.23210-1-s.hauer@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
>
> diff --git a/rules/nodejs_packages.make b/rules/nodejs_packages.make
> index e96382f625c8..bf533cc921be 100644
> --- a/rules/nodejs_packages.make
> +++ b/rules/nodejs_packages.make
> @@ -59,7 +59,7 @@ $(STATEDIR)/nodejs_packages.compile:
> touch $(YARN_LOCK); \
> ln -fs $(YARN_LOCK) $(NODEJS_PACKAGES_DIR)/yarn.lock; \
> fi
> - yarn $(YARN_OPTS) add $(NODEJS_PACKAGES_LIST)
> + $(call node/env, yarn $(YARN_OPTS) add $(NODEJS_PACKAGES_LIST))
> @find $(NODEJS_PACKAGES_CACHE) -type f -name '.yarn-tarball.tgz' -delete
> @$(call touch)
>
_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de
prev parent reply other threads:[~2021-03-05 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 9:47 [ptxdist] [PATCH] " Sascha Hauer
2021-03-05 7:26 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1lI4qn-000ANc-4X@dude03.red.stw.pengutronix.de \
--to=mol@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox