mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: [ptxdist] [PATCH] nodejs_packages: Call yarn in the right environment
Date: Tue,  2 Mar 2021 10:47:45 +0100	[thread overview]
Message-ID: <20210302094745.23210-1-s.hauer@pengutronix.de> (raw)

Call yarn in node/env to actually cross compile native packages.
Without it the host compiler is used and installation of native packages
ends with something like:

arm-v7a-linux-gnueabihf-strip: platform/packages/nodejs_packages-0.0.1/usr/lib/node_modules/epoll/build/Release/obj.target/epoll.node: file format not recognized

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 rules/nodejs_packages.make | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rules/nodejs_packages.make b/rules/nodejs_packages.make
index e96382f62..bf533cc92 100644
--- a/rules/nodejs_packages.make
+++ b/rules/nodejs_packages.make
@@ -59,7 +59,7 @@ $(STATEDIR)/nodejs_packages.compile:
 		touch $(YARN_LOCK); \
 		ln -fs $(YARN_LOCK) $(NODEJS_PACKAGES_DIR)/yarn.lock; \
 	fi
-	yarn $(YARN_OPTS) add $(NODEJS_PACKAGES_LIST)
+	$(call node/env, yarn $(YARN_OPTS) add $(NODEJS_PACKAGES_LIST))
 	@find $(NODEJS_PACKAGES_CACHE) -type f -name '.yarn-tarball.tgz' -delete
 	@$(call touch)
 
-- 
2.29.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

             reply	other threads:[~2021-03-02  9:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02  9:47 Sascha Hauer [this message]
2021-03-05  7:26 ` [ptxdist] [APPLIED] " Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210302094745.23210-1-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox