[ptxdist] [PATCH] networkmanager: ppp support requires GLOBAL_IPV6

[ptxdist] [PATCH] networkmanager: ppp support requires GLOBAL_IPV6

[Denis Osterland-Heim]

pppd installs eui64.h only if GLOBAL_IPV6 is set,
but networkmanager ppp support includes this header without a check.
This patch allows to enable ppp support only if GLOBAL_IPV6 is
selected to avoid a compile error.

Signed-off-by: Denis Osterland-Heim <Denis.Osterland@diehl.com>
---
 rules/networkmanager.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/rules/networkmanager.in b/rules/networkmanager.in
index dbbc3d072..16703ea6c 100644
--- a/rules/networkmanager.in
+++ b/rules/networkmanager.in
@@ -86,8 +86,12 @@ config NETWORKMANAGER_WWAN
 
 config NETWORKMANAGER_PPP
 	bool
+	depends on GLOBAL_IPV6
 	prompt "enable ppp support"
 
+comment "ppp support requires GLOBAL_IPV6!"
+	depends on !GLOBAL_IPV6
+
 config NETWORKMANAGER_CONCHECK
 	bool
 	prompt "enable connectivity checking support"
-- 
2.26.0



Diehl Connectivity Solutions GmbH
Geschäftsführung: Horst Leonberger
Sitz der Gesellschaft: Nürnberg - Registergericht: Amtsgericht
Nürnberg: HRB 32315
___________________________________________________________________________________________________

Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen.
Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht.
Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt.
- Informationen zum Datenschutz, insbesondere zu Ihren Rechten, erhalten Sie unter https://www.diehl.com/group/de/transparenz-und-informationspflichten/

The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by
mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. 
- For general information on data protection and your respective rights please visit https://www.diehl.com/group/en/transparency-and-information-obligations/

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] networkmanager: ppp support requires GLOBAL_IPV6

[Michael Olbrich]

Thanks, applied as dbe8214201eeacd4387bea27779eab2967b5d0c8.

Michael

[sent from post-receive hook]

On Thu, 02 Apr 2020 17:03:32 +0200, Denis Osterland-Heim <denis.osterland@diehl.com> wrote:
> pppd installs eui64.h only if GLOBAL_IPV6 is set,
> but networkmanager ppp support includes this header without a check.
> This patch allows to enable ppp support only if GLOBAL_IPV6 is
> selected to avoid a compile error.
> 
> Signed-off-by: Denis Osterland-Heim <Denis.Osterland@diehl.com>
> ---
>  rules/networkmanager.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/rules/networkmanager.in b/rules/networkmanager.in
> index dbbc3d072..16703ea6c 100644
> --- a/rules/networkmanager.in
> +++ b/rules/networkmanager.in
> @@ -86,8 +86,12 @@ config NETWORKMANAGER_WWAN
>  
>  config NETWORKMANAGER_PPP
>  	bool
> +	depends on GLOBAL_IPV6
>  	prompt "enable ppp support"
>  
> +comment "ppp support requires GLOBAL_IPV6!"
> +	depends on !GLOBAL_IPV6
> +
>  config NETWORKMANAGER_CONCHECK
>  	bool
>  	prompt "enable connectivity checking support"
> 

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de