Re: [ptxdist] [PATCH] libtahu: new package

[Ian Abbott <abbotti@mev.co.uk>]

On 17/02/2023 06:19, Michael Olbrich wrote:
> On Thu, Feb 16, 2023 at 12:09:44PM +0000, Ian Abbott wrote:
>> Includes the C library from the Eclipse Tahu project that provides an
>> implementation of the Sparkplug specification.  This package does not
>> include the implementations from the Tahu project for other programming
>> languages other than C.
>>
>> Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
>> ---
>>   rules/libtahu.in   | 11 ++++++
>>   rules/libtahu.make | 88 ++++++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 99 insertions(+)
>>   create mode 100644 rules/libtahu.in
>>   create mode 100644 rules/libtahu.make
[...]
>> diff --git a/rules/libtahu.make b/rules/libtahu.make
>> new file mode 100644
>> index 000000000..c4e62cc61
>> --- /dev/null
>> +++ b/rules/libtahu.make
[...]
>> +LIBTAHU_LICENSE	:= EPL-2.0
>> +LIBTAHU_LICENSE_FILES	:= \
>> +	file://LICENSE;md5=c7cc8aa73fb5717f8291fcec5ce9ed6c \
> 
> The filename is spelled LICENCE ...

OK.

> 
>> +	file://epl-v20.html;md5=84283fa8859daf213bdda5a9f8d1be1d
> 
> That's the same text just in html, so this is not needed.
> 
> But I would add notice.html because many files have no license header and
> this file contains: "... Unless otherwise indicated, all Content made
> available by the Eclipse Foundation is provided to you under the terms and
> conditions of the Eclipse Public License Version 2.0 ..."
> So this clarifies what the correct license is.

OK.

[...]
>> +# Default target builds tests that depend on libmosquitto, so just build
>> +# the library files.
>> +LIBTAHU_MAKE_OPT	:= \
>> +	$(CROSS_ENV_CC) \
>> +	$(CROSS_ENV_AR) \
>> +	$(CROSS_ENV_LD) \
> 
> Replace all 3 lines with $(CROSS_ENV_PROGS)
> 
>> +	lib/libtahu.so \
>> +	lib/libtahu.a
> 
> Why the static library as well? We usually don't build it in ptxdist.

Fair enough.  I'll remove it.

> 
>> +
>> +# ----------------------------------------------------------------------------
>> +# Install
>> +# ----------------------------------------------------------------------------
>> +
>> +$(STATEDIR)/libtahu.install:
>> +	@$(call targetinfo)
>> +	@install -m 644 -D -t "$(LIBTAHU_PKGDIR)/usr/lib" \
>> +		"$(LIBTAHU_DIR)/$(LIBTAHU_SUBDIR)/lib/libtahu.so" \
>> +		"$(LIBTAHU_DIR)/$(LIBTAHU_SUBDIR)/lib/libtahu.a"
>> +	@install -m 644 -D -t "$(LIBTAHU_PKGDIR)/usr/include" \
> 
> add '-v' (for both) so we can see what is installed in the log.

OK.

Thanks for the review.  I'll send a v2 patch shortly.

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-