From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 17 Feb 2023 11:18:52 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pSxpM-00A3DE-GV for lore@lore.pengutronix.de; Fri, 17 Feb 2023 11:18:52 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pSxpL-0004QS-4r; Fri, 17 Feb 2023 11:18:51 +0100 Received: from smtp110.ord1d.emailsrvr.com ([184.106.54.110]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSxos-0004Px-L8 for ptxdist@pengutronix.de; Fri, 17 Feb 2023 11:18:23 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mev.co.uk; s=20221208-6x11dpa4; t=1676629100; bh=gmiygTL4cPM9vKS8h3d88PZn+/eUHZO2LtSzlNuGWPY=; h=Date:Subject:To:From:From; b=IsFCeclHjAPOHei1tOB9b5j0g/1VLoyF74LI7sYR8+x7ES1476GzZCvMQLM4nJxn3 iA5MEdBihLmIA6/FM/8drBYsEV/LAFe9Jc3zX1e1nnPa7bi0UxxgqRaW3KFhbWbT5S 9Cs/4Kd7I9g2VoZfczNtyWVDBcaTCX+yDC6XPCsw= X-Auth-ID: abbotti@mev.co.uk Received: by smtp22.relay.ord1d.emailsrvr.com (Authenticated sender: abbotti-AT-mev.co.uk) with ESMTPSA id 2D727E00A6 for ; Fri, 17 Feb 2023 05:18:20 -0500 (EST) Message-ID: <9d614b61-4a11-9bb3-966e-3da4513bb2be@mev.co.uk> Date: Fri, 17 Feb 2023 10:18:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Content-Language: en-GB To: ptxdist@pengutronix.de References: <20230216120944.26693-1-abbotti@mev.co.uk> From: Ian Abbott Organization: MEV Ltd. In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Classification-ID: 8a7cff97-1bb7-4048-9a00-3e543cc479ca-1-1 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH] libtahu: new package X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On 17/02/2023 06:19, Michael Olbrich wrote: > On Thu, Feb 16, 2023 at 12:09:44PM +0000, Ian Abbott wrote: >> Includes the C library from the Eclipse Tahu project that provides an >> implementation of the Sparkplug specification. This package does not >> include the implementations from the Tahu project for other programming >> languages other than C. >> >> Signed-off-by: Ian Abbott >> --- >> rules/libtahu.in | 11 ++++++ >> rules/libtahu.make | 88 ++++++++++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 99 insertions(+) >> create mode 100644 rules/libtahu.in >> create mode 100644 rules/libtahu.make [...] >> diff --git a/rules/libtahu.make b/rules/libtahu.make >> new file mode 100644 >> index 000000000..c4e62cc61 >> --- /dev/null >> +++ b/rules/libtahu.make [...] >> +LIBTAHU_LICENSE := EPL-2.0 >> +LIBTAHU_LICENSE_FILES := \ >> + file://LICENSE;md5=c7cc8aa73fb5717f8291fcec5ce9ed6c \ > > The filename is spelled LICENCE ... OK. > >> + file://epl-v20.html;md5=84283fa8859daf213bdda5a9f8d1be1d > > That's the same text just in html, so this is not needed. > > But I would add notice.html because many files have no license header and > this file contains: "... Unless otherwise indicated, all Content made > available by the Eclipse Foundation is provided to you under the terms and > conditions of the Eclipse Public License Version 2.0 ..." > So this clarifies what the correct license is. OK. [...] >> +# Default target builds tests that depend on libmosquitto, so just build >> +# the library files. >> +LIBTAHU_MAKE_OPT := \ >> + $(CROSS_ENV_CC) \ >> + $(CROSS_ENV_AR) \ >> + $(CROSS_ENV_LD) \ > > Replace all 3 lines with $(CROSS_ENV_PROGS) > >> + lib/libtahu.so \ >> + lib/libtahu.a > > Why the static library as well? We usually don't build it in ptxdist. Fair enough. I'll remove it. > >> + >> +# ---------------------------------------------------------------------------- >> +# Install >> +# ---------------------------------------------------------------------------- >> + >> +$(STATEDIR)/libtahu.install: >> + @$(call targetinfo) >> + @install -m 644 -D -t "$(LIBTAHU_PKGDIR)/usr/lib" \ >> + "$(LIBTAHU_DIR)/$(LIBTAHU_SUBDIR)/lib/libtahu.so" \ >> + "$(LIBTAHU_DIR)/$(LIBTAHU_SUBDIR)/lib/libtahu.a" >> + @install -m 644 -D -t "$(LIBTAHU_PKGDIR)/usr/include" \ > > add '-v' (for both) so we can see what is installed in the log. OK. Thanks for the review. I'll send a v2 patch shortly. -- -=( Ian Abbott || MEV Ltd. is a company )=- -=( registered in England & Wales. Regd. number: 02862268. )=- -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=- -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-