[ptxdist] Invalid KERNEL_DTS_PATH description and default?

[ptxdist] Invalid KERNEL_DTS_PATH description and default?

[Christian Melki]

KERNEL_DTS_PATH in rules/kernel.in.

"Multiple directories can be specified separated by ':'"
Hmm. Should be space?

Also,
"${PTXDIST_PLATFORMCONFIG_SUBDIR}/dts:${KERNEL_DIR}/arch/${GENERIC_KERNEL_ARCH}/boot/dts"
as default.

${PTXDIST_PLATFORMCONFIG_SUBDIR} is a partial path and ${KERNEL_DIR} is
an absolute path. How is that supposed to work?

Regards,
Christian

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

[ptxdist] [PATCH] kernel: fix and improve DTS help texts

[Michael Olbrich]

Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
---

The default is correct. The paths are separated by colon and _one_ of the
paths can be relative. The help text could be better. Maybe something like
this?

Michael

 platforms/kernel.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/platforms/kernel.in b/platforms/kernel.in
index ff3cc8df4f47..06b6e24a6756 100644
--- a/platforms/kernel.in
+++ b/platforms/kernel.in
@@ -185,14 +185,16 @@ config KERNEL_DTS_PATH
 	default "${PTXDIST_PLATFORMCONFIG_SUBDIR}/dts:${KERNEL_DIR}/arch/${GENERIC_KERNEL_ARCH}/boot/dts"
 	help
 	  Define path to the dts source file. Multiple directories can be
-	  specified separated by ':'.
+	  specified separated by ':'. A relative path will be expanded relative
+	  to the workspace and all other layers. Only on of the specified paths
+	  can be a relative path.
 
 config KERNEL_DTS
 	string "source dts file"
 	default "<yourboard>.dts"
 	help
 	  Select the dts file to use for the device tree binary
-	  blob generation. For relative file names DTC_OFTREE_DTS_PATH
+	  blob generation. For relative file names KERNEL_DTS_PATH
 	  is used as a search path for the device tree files specified
 	  here. Multiple dts files can be specified, separated by spaces.
 
-- 
2.30.2


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de

Re: [ptxdist] [PATCH] kernel: fix and improve DTS help texts

[Christian Melki]

Hmm.

You're right. I probably misread the functionality as I tried to 
implement "make dtbs". Which isn't going to align with the current 
functionality IIUC?

I'm fine with the increased verbosity. My main goal was "make dtbs" for 
vendor kernels that are a bit obnoxious.

Regards,
Christian

On 9/8/21 3:58 PM, Michael Olbrich wrote:
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> ---
> 
> The default is correct. The paths are separated by colon and _one_ of the
> paths can be relative. The help text could be better. Maybe something like
> this?
> 
> Michael
> 
>   platforms/kernel.in | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/platforms/kernel.in b/platforms/kernel.in
> index ff3cc8df4f47..06b6e24a6756 100644
> --- a/platforms/kernel.in
> +++ b/platforms/kernel.in
> @@ -185,14 +185,16 @@ config KERNEL_DTS_PATH
>   	default "${PTXDIST_PLATFORMCONFIG_SUBDIR}/dts:${KERNEL_DIR}/arch/${GENERIC_KERNEL_ARCH}/boot/dts"
>   	help
>   	  Define path to the dts source file. Multiple directories can be
> -	  specified separated by ':'.
> +	  specified separated by ':'. A relative path will be expanded relative
> +	  to the workspace and all other layers. Only on of the specified paths
> +	  can be a relative path.
>   
>   config KERNEL_DTS
>   	string "source dts file"
>   	default "<yourboard>.dts"
>   	help
>   	  Select the dts file to use for the device tree binary
> -	  blob generation. For relative file names DTC_OFTREE_DTS_PATH
> +	  blob generation. For relative file names KERNEL_DTS_PATH
>   	  is used as a search path for the device tree files specified
>   	  here. Multiple dts files can be specified, separated by spaces.
>   
> 

_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de
To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de