[ptxdist] [PATCH] tcpreplay: new package

[ptxdist] [PATCH] tcpreplay: new package

[Bastian Krause]

Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
 rules/tcpreplay.in   |  9 +++++
 rules/tcpreplay.make | 80 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 89 insertions(+)
 create mode 100644 rules/tcpreplay.in
 create mode 100644 rules/tcpreplay.make

diff --git a/rules/tcpreplay.in b/rules/tcpreplay.in
new file mode 100644
index 000000000..bd1791744
--- /dev/null
+++ b/rules/tcpreplay.in
@@ -0,0 +1,9 @@
+## SECTION=networking
+
+config TCPREPLAY
+	tristate
+	prompt "tcpreplay"
+	select LIBPCAP
+	help
+	  tcpreplay is a suite of free Open Source utilities for editing and
+	  replaying previously captured network traffic.
diff --git a/rules/tcpreplay.make b/rules/tcpreplay.make
new file mode 100644
index 000000000..3f1568ad0
--- /dev/null
+++ b/rules/tcpreplay.make
@@ -0,0 +1,80 @@
+# -*-makefile-*-
+#
+# Copyright (C) 2024 by Bastian Krause <bst@pengutronix.de>
+#
+# For further information about the PTXdist project and license conditions
+# see the README file.
+#
+
+#
+# We provide this package
+#
+PACKAGES-$(PTXCONF_TCPREPLAY) += tcpreplay
+
+#
+# Paths and names
+#
+TCPREPLAY_VERSION	:= 4.5.1
+TCPREPLAY_MD5		:= 53375102b54b3e6ef124f6ae85836092
+TCPREPLAY		:= tcpreplay-$(TCPREPLAY_VERSION)
+TCPREPLAY_SUFFIX	:= tar.xz
+TCPREPLAY_URL		:= https://github.com/appneta/tcpreplay/releases/download/v$(TCPREPLAY_VERSION)/$(TCPREPLAY).$(TCPREPLAY_SUFFIX)
+TCPREPLAY_SOURCE	:= $(SRCDIR)/$(TCPREPLAY).$(TCPREPLAY_SUFFIX)
+TCPREPLAY_DIR		:= $(BUILDDIR)/$(TCPREPLAY)
+TCPREPLAY_LICENSE	:= GPL-3.0-only
+TCPREPLAY_LICENSE_FILES := \
+	file://docs/LICENSE;md5=10f0474a2f0e5dccfca20f69d6598ad8
+
+# ----------------------------------------------------------------------------
+# Prepare
+# ----------------------------------------------------------------------------
+
+#
+# autoconf
+#
+TCPREPLAY_CONF_TOOL	:= autoconf
+TCPREPLAY_CONF_OPT	:= \
+	$(CROSS_AUTOCONF_USR) \
+	$(GLOBAL_LARGE_FILE_OPTION) \
+	--disable-asan \
+	--disable-tsan \
+	--disable-debug \
+	--disable-extra-debug \
+	--disable-dmalloc \
+	--disable-efence \
+	--disable-gprof \
+	--disable-pcapconfig \
+	--enable-dynamic-link \
+	--disable-tuntap \
+	--disable-nls \
+	--enable-local-libopts \
+	--disable-libopts-install \
+	--with-libpcap=$(PTXDIST_SYSROOT_TARGET)/usr \
+	--without-netmap \
+	--without-libdnet \
+	--without-pcapnav-config \
+	--without-tcpdump \
+	--without-autoopts-config \
+	--without-regex-header \
+	--without-libregex
+
+# ----------------------------------------------------------------------------
+# Target-Install
+# ----------------------------------------------------------------------------
+
+$(STATEDIR)/tcpreplay.targetinstall:
+	@$(call targetinfo)
+
+	@$(call install_init, tcpreplay)
+	@$(call install_fixup, tcpreplay,PRIORITY,optional)
+	@$(call install_fixup, tcpreplay,SECTION,base)
+	@$(call install_fixup, tcpreplay,AUTHOR,"Bastian Krause <bst@pengutronix.de>")
+	@$(call install_fixup, tcpreplay,DESCRIPTION,missing)
+
+	@$(call install_copy, tcpreplay, 0, 0, 0755, -, /usr/bin/tcpreplay)
+
+	@$(call install_finish, tcpreplay)
+
+	@$(call touch)
+
+# vim: syntax=make
-- 
2.39.5

Re: [ptxdist] [PATCH] tcpreplay: new package

[Roland Hieber]

On Wed, Sep 18, 2024 at 03:37:13PM +0200, Bastian Krause wrote:
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> ---
>  rules/tcpreplay.in   |  9 +++++
>  rules/tcpreplay.make | 80 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 89 insertions(+)
>  create mode 100644 rules/tcpreplay.in
>  create mode 100644 rules/tcpreplay.make
> 
> diff --git a/rules/tcpreplay.in b/rules/tcpreplay.in
> new file mode 100644
> index 000000000..bd1791744
> --- /dev/null
> +++ b/rules/tcpreplay.in
> @@ -0,0 +1,9 @@
> +## SECTION=networking
> +
> +config TCPREPLAY
> +	tristate
> +	prompt "tcpreplay"
> +	select LIBPCAP
> +	help
> +	  tcpreplay is a suite of free Open Source utilities for editing and
> +	  replaying previously captured network traffic.
> diff --git a/rules/tcpreplay.make b/rules/tcpreplay.make
> new file mode 100644
> index 000000000..3f1568ad0
> --- /dev/null
> +++ b/rules/tcpreplay.make
> @@ -0,0 +1,80 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2024 by Bastian Krause <bst@pengutronix.de>
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_TCPREPLAY) += tcpreplay
> +
> +#
> +# Paths and names
> +#
> +TCPREPLAY_VERSION	:= 4.5.1
> +TCPREPLAY_MD5		:= 53375102b54b3e6ef124f6ae85836092
> +TCPREPLAY		:= tcpreplay-$(TCPREPLAY_VERSION)
> +TCPREPLAY_SUFFIX	:= tar.xz
> +TCPREPLAY_URL		:= https://github.com/appneta/tcpreplay/releases/download/v$(TCPREPLAY_VERSION)/$(TCPREPLAY).$(TCPREPLAY_SUFFIX)
> +TCPREPLAY_SOURCE	:= $(SRCDIR)/$(TCPREPLAY).$(TCPREPLAY_SUFFIX)
> +TCPREPLAY_DIR		:= $(BUILDDIR)/$(TCPREPLAY)
> +TCPREPLAY_LICENSE	:= GPL-3.0-only
> +TCPREPLAY_LICENSE_FILES := \
> +	file://docs/LICENSE;md5=10f0474a2f0e5dccfca20f69d6598ad8

This is GPL software, please include at least one file mentioning that
it's under GPL, like:

  file://src/tcpreplay.c;startline=4;endline=15;md5=9b41c5c891f51dfe9669e794a1d680c7

(… which looks like a GPL-3.0-or-later dedication, but it has "or with
the authors permission any later version." instead of "or at your option
any later version"… so I guess GPL-3.0-only is okay here.)

Additionally, docs/LICENSE states:

  Please note that this license covers the files that I have written.
  Some files distributed with the Tcpreplay Suite are copyrighted by 
  other authors and have a different license. These files & directories
  are marked as such. […]

by which is probably meant:

  file://src/common/err.c;startline=14;endline=43;md5=0fd028531634bf7aba2791035e3c2de4

which is BSD-4-Clause-UC, and

  file://src/common/fakepoll.c;startline=8;endline=36;md5=903f05912a12e9a01b3018b915a1a7df

which is BSD-3-Clause, and some bible quotes in src/fragroute/bget.c
(wtf?) which are probably not relevant for licensing.

Other than that, patch looks fine to me.

 - Roland

> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#
> +# autoconf
> +#
> +TCPREPLAY_CONF_TOOL	:= autoconf
> +TCPREPLAY_CONF_OPT	:= \
> +	$(CROSS_AUTOCONF_USR) \
> +	$(GLOBAL_LARGE_FILE_OPTION) \
> +	--disable-asan \
> +	--disable-tsan \
> +	--disable-debug \
> +	--disable-extra-debug \
> +	--disable-dmalloc \
> +	--disable-efence \
> +	--disable-gprof \
> +	--disable-pcapconfig \
> +	--enable-dynamic-link \
> +	--disable-tuntap \
> +	--disable-nls \
> +	--enable-local-libopts \
> +	--disable-libopts-install \
> +	--with-libpcap=$(PTXDIST_SYSROOT_TARGET)/usr \
> +	--without-netmap \
> +	--without-libdnet \
> +	--without-pcapnav-config \
> +	--without-tcpdump \
> +	--without-autoopts-config \
> +	--without-regex-header \
> +	--without-libregex
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/tcpreplay.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, tcpreplay)
> +	@$(call install_fixup, tcpreplay,PRIORITY,optional)
> +	@$(call install_fixup, tcpreplay,SECTION,base)
> +	@$(call install_fixup, tcpreplay,AUTHOR,"Bastian Krause <bst@pengutronix.de>")
> +	@$(call install_fixup, tcpreplay,DESCRIPTION,missing)
> +
> +	@$(call install_copy, tcpreplay, 0, 0, 0755, -, /usr/bin/tcpreplay)
> +
> +	@$(call install_finish, tcpreplay)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 2.39.5
> 
> 
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |

Re: [ptxdist] [APPLIED] tcpreplay: new package

[Michael Olbrich]

Thanks, applied as 9e289395916697011efb054da69557bd5bfc0f39.

Michael

[sent from post-receive hook]

On Tue, 24 Sep 2024 17:07:54 +0200, Bastian Krause <bst@pengutronix.de> wrote:
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> Message-Id: <20240918133713.899183-1-bst@pengutronix.de>
> Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> diff --git a/rules/tcpreplay.in b/rules/tcpreplay.in
> new file mode 100644
> index 000000000000..bd1791744300
> --- /dev/null
> +++ b/rules/tcpreplay.in
> @@ -0,0 +1,9 @@
> +## SECTION=networking
> +
> +config TCPREPLAY
> +	tristate
> +	prompt "tcpreplay"
> +	select LIBPCAP
> +	help
> +	  tcpreplay is a suite of free Open Source utilities for editing and
> +	  replaying previously captured network traffic.
> diff --git a/rules/tcpreplay.make b/rules/tcpreplay.make
> new file mode 100644
> index 000000000000..3f1568ad0db9
> --- /dev/null
> +++ b/rules/tcpreplay.make
> @@ -0,0 +1,80 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2024 by Bastian Krause <bst@pengutronix.de>
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_TCPREPLAY) += tcpreplay
> +
> +#
> +# Paths and names
> +#
> +TCPREPLAY_VERSION	:= 4.5.1
> +TCPREPLAY_MD5		:= 53375102b54b3e6ef124f6ae85836092
> +TCPREPLAY		:= tcpreplay-$(TCPREPLAY_VERSION)
> +TCPREPLAY_SUFFIX	:= tar.xz
> +TCPREPLAY_URL		:= https://github.com/appneta/tcpreplay/releases/download/v$(TCPREPLAY_VERSION)/$(TCPREPLAY).$(TCPREPLAY_SUFFIX)
> +TCPREPLAY_SOURCE	:= $(SRCDIR)/$(TCPREPLAY).$(TCPREPLAY_SUFFIX)
> +TCPREPLAY_DIR		:= $(BUILDDIR)/$(TCPREPLAY)
> +TCPREPLAY_LICENSE	:= GPL-3.0-only
> +TCPREPLAY_LICENSE_FILES := \
> +	file://docs/LICENSE;md5=10f0474a2f0e5dccfca20f69d6598ad8
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#
> +# autoconf
> +#
> +TCPREPLAY_CONF_TOOL	:= autoconf
> +TCPREPLAY_CONF_OPT	:= \
> +	$(CROSS_AUTOCONF_USR) \
> +	$(GLOBAL_LARGE_FILE_OPTION) \
> +	--disable-asan \
> +	--disable-tsan \
> +	--disable-debug \
> +	--disable-extra-debug \
> +	--disable-dmalloc \
> +	--disable-efence \
> +	--disable-gprof \
> +	--disable-pcapconfig \
> +	--enable-dynamic-link \
> +	--disable-tuntap \
> +	--disable-nls \
> +	--enable-local-libopts \
> +	--disable-libopts-install \
> +	--with-libpcap=$(PTXDIST_SYSROOT_TARGET)/usr \
> +	--without-netmap \
> +	--without-libdnet \
> +	--without-pcapnav-config \
> +	--without-tcpdump \
> +	--without-autoopts-config \
> +	--without-regex-header \
> +	--without-libregex
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/tcpreplay.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, tcpreplay)
> +	@$(call install_fixup, tcpreplay,PRIORITY,optional)
> +	@$(call install_fixup, tcpreplay,SECTION,base)
> +	@$(call install_fixup, tcpreplay,AUTHOR,"Bastian Krause <bst@pengutronix.de>")
> +	@$(call install_fixup, tcpreplay,DESCRIPTION,missing)
> +
> +	@$(call install_copy, tcpreplay, 0, 0, 0755, -, /usr/bin/tcpreplay)
> +
> +	@$(call install_finish, tcpreplay)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make